Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2646743003: histograms.xml: Add missing new value for FirstRunResult. (Closed)

Created:
3 years, 11 months ago by digit1
Modified:
3 years, 11 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

histograms.xml: Add missing new value for FirstRunResult. This is a follow-up to https://codereview.chromium.org/2605293002/ which introduced a new enum value in the Variations.FirstRunResult historgram to account for seed import failure, in the case of an invalid response date string. BUG=669625 R=asvitkine@chromium.org Review-Url: https://codereview.chromium.org/2646743003 Cr-Commit-Position: refs/heads/master@{#445051} Committed: https://chromium.googlesource.com/chromium/src/+/0e2de9dbb7a8507438b24f2a70be000ccb7a8265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Alexei Svitkine (slow)
lgtm
3 years, 11 months ago (2017-01-19 18:27:53 UTC) #1
digit1
jochen@chromium.org: Please review changes in histograms.xml Interestingly, Alexei is in tools/metrics/OWNERS but not in tools/metrics/histograms/OWNERS.
3 years, 11 months ago (2017-01-20 09:58:15 UTC) #3
jochen (gone - plz use gerrit)
and he's also the right reviewer for this CL :)
3 years, 11 months ago (2017-01-20 13:07:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646743003/1
3 years, 11 months ago (2017-01-20 14:36:57 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 14:41:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e2de9dbb7a8507438b24f2a70be...

Powered by Google App Engine
This is Rietveld 408576698