Add WARN_UNUSED_RESULT to base::Time methods that return bool.

components/variations/variations_seed_store.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/variations/variations_seed_store.h"
 
 #include <stdint.h>
 
 #include "base/base64.h"
 #include "base/macros.h"
@@ skipping 121 matching lines @@
   }
   return SEED_DATE_SAME_DAY;
 }
 
 #if defined(OS_ANDROID)
 enum FirstRunResult {
   FIRST_RUN_SEED_IMPORT_SUCCESS,
   FIRST_RUN_SEED_IMPORT_FAIL_NO_CALLBACK,
   FIRST_RUN_SEED_IMPORT_FAIL_NO_FIRST_RUN_SEED,
   FIRST_RUN_SEED_IMPORT_FAIL_STORE_FAILED,
+  FIRST_RUN_SEED_IMPORT_FAIL_INVALID_RESPONSE_DATE,

[Alexei Svitkine (slow), 2017/01/17 21:38:07]

Can you add this to histograms.xml? Seems like you forgot to do this as part of
the change.

[digit1, 2017/01/19 12:57:41]

Thanks for spotting this. Please see the new patch at
https://codereview.chromium.org/2646743003

   FIRST_RUN_RESULT_ENUM_SIZE,
 };
 
 void RecordFirstRunResult(FirstRunResult result) {
   UMA_HISTOGRAM_ENUMERATION("Variations.FirstRunResult", result,
                             FIRST_RUN_RESULT_ENUM_SIZE);
 }
 #endif  // OS_ANDROID
 
 }  // namespace
@@ skipping 208 matching lines @@
   bool is_gzip_compressed;
 
   android::GetVariationsFirstRunSeed(&seed_data, &seed_signature, &seed_country,
                                      &response_date, &is_gzip_compressed);
   if (seed_data.empty()) {
     RecordFirstRunResult(FIRST_RUN_SEED_IMPORT_FAIL_NO_FIRST_RUN_SEED);
     return;
   }
 
   base::Time current_date;
-  base::Time::FromUTCString(response_date.c_str(), &current_date);
+  if (!base::Time::FromUTCString(response_date.c_str(), &current_date)) {
+    RecordFirstRunResult(FIRST_RUN_SEED_IMPORT_FAIL_INVALID_RESPONSE_DATE);
+    LOG(WARNING) << "Invalid response date: " << response_date;
+    return;
+  }
 
   if (!StoreSeedData(seed_data, seed_signature, seed_country, current_date,
                      false, is_gzip_compressed, nullptr)) {
     RecordFirstRunResult(FIRST_RUN_SEED_IMPORT_FAIL_STORE_FAILED);
     LOG(WARNING) << "First run variations seed is invalid.";
     return;
   }
   RecordFirstRunResult(FIRST_RUN_SEED_IMPORT_SUCCESS);
 }
 #endif  // OS_ANDROID
@@ skipping 150 matching lines @@
   }
   return true;
 }
 
 void VariationsSeedStore::ReportUnsupportedSeedFormatError() {
   RecordSeedStoreHistogram(
       VARIATIONS_SEED_STORE_FAILED_UNSUPPORTED_SEED_FORMAT);
 }
 
 }  // namespace variations