Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2605133002: Add method to delete storage for origins to LocalStorageContextMojo. (Closed)

Created:
3 years, 11 months ago by Marijn Kruisselbrink
Modified:
3 years, 11 months ago
Reviewers:
michaeln, jam
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add method to delete storage for origins to LocalStorageContextMojo. Also changes LevelDBWrapperImpl to not unnecessary read all the existing data if it is immediately going to delete it all anyway. BUG=586194 Committed: https://crrev.com/a9c2a3c1911c2845d336e50f57986470ae7dabb1 Cr-Commit-Position: refs/heads/master@{#440984}

Patch Set 1 #

Patch Set 2 : more tests #

Patch Set 3 : fix #

Patch Set 4 : delete storage for physical origin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -41 lines) Patch
M content/browser/dom_storage/local_storage_context_mojo.h View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo.cc View 1 2 3 6 chunks +58 lines, -15 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo_unittest.cc View 1 2 3 3 chunks +228 lines, -0 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.h View 1 2 chunks +23 lines, -19 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.cc View 2 chunks +17 lines, -2 lines 0 comments Download
M content/browser/leveldb_wrapper_impl_unittest.cc View 1 4 chunks +46 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (16 generated)
Marijn Kruisselbrink
3 years, 11 months ago (2016-12-29 19:09:35 UTC) #11
jam
lgtm
3 years, 11 months ago (2016-12-29 20:39:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605133002/60001
3 years, 11 months ago (2016-12-29 20:47:11 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
3 years, 11 months ago (2016-12-29 20:50:56 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:53:06 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a9c2a3c1911c2845d336e50f57986470ae7dabb1
Cr-Commit-Position: refs/heads/master@{#440984}

Powered by Google App Engine
This is Rietveld 408576698