Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 260513004: DevTools: [Console] fix sourceurl when exception happens before inspector is open (Closed)

Created:
6 years, 7 months ago by kozyatinskiy1
Modified:
6 years, 6 months ago
Reviewers:
vsevik, yurys
CC:
blink-reviews, adamk+blink_chromium.org, aandrey+blink_chromium.org, caseq+blink_chromium.org, arv+blink, malch+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, Nate Chapin, jsbell+bindings_chromium.org, alph+blink_chromium.org, kouhei+bindings_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools: [Console] fix sourceurl when exception happens before inspector is open When exception happens before inspector is open source url (from //# sourceURL=) is correctly shown in console. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176862

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -3 lines) Patch
A LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html View 1 2 4 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/inspector-enabled/console-exception-source-url-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/inspector-enabled/console-stack-overflow-source-url.html View 1 2 4 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/inspector-enabled/console-stack-overflow-source-url-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/v8/V8Initializer.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/WorkerScriptController.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
vsevik
https://codereview.chromium.org/260513004/diff/20001/LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html File LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html (right): https://codereview.chromium.org/260513004/diff/20001/LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html#newcode30 LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html:30: InspectorTest.addResult("Message: " + WebInspector.displayNameForURL(m.url) + ":" + m.line + ...
6 years, 7 months ago (2014-04-30 10:23:56 UTC) #1
vsevik
https://chromiumcodereview.appspot.com/260513004/diff/60001/LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html File LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html (right): https://chromiumcodereview.appspot.com/260513004/diff/60001/LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html#newcode15 LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html:15: //# sourceURL=outer_src I don't think this is needed here ...
6 years, 7 months ago (2014-04-30 15:16:58 UTC) #2
kozyatinskiy1
https://codereview.chromium.org/260513004/diff/60001/LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html File LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html (right): https://codereview.chromium.org/260513004/diff/60001/LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html#newcode15 LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html:15: //# sourceURL=outer_src On 2014/04/30 15:16:59, vsevik wrote: > I ...
6 years, 7 months ago (2014-04-30 16:08:03 UTC) #3
vsevik
lgtm, but we should wait for the v8 to update before landing it.
6 years, 7 months ago (2014-05-01 06:55:32 UTC) #4
vsevik
yurys@, Please take a look
6 years, 6 months ago (2014-06-04 14:26:49 UTC) #5
yurys
lgtm
6 years, 6 months ago (2014-06-05 08:51:42 UTC) #6
kozyatinskiy1
Replaced GetScriptResourceName() with GetScriptOrigin().ResourceName(). Depends on https://codereview.chromium.org/265593002/
6 years, 6 months ago (2014-06-16 12:06:19 UTC) #7
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 6 months ago (2014-06-24 15:33:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/260513004/140001
6 years, 6 months ago (2014-06-24 15:34:04 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-24 17:15:49 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 18:11:48 UTC) #11
Message was sent while issue was closed. 
Change committed as 176862

Powered by Google App Engine
This is Rietveld 408576698