LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html - Issue 260513004: DevTools: [Console] fix sourceurl when exception happens before inspector is open

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/inspector-enabled/console-exception-source-url.html

Issue 260513004: DevTools: [Console] fix sourceurl when exception happens before inspector is open (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/inspector-enabled/console-exception-source-url-expected.txt » ('j') | LayoutTests/http/tests/inspector-enabled/console-stack-overflow-source-url.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../inspector/inspector-test.js"></script>

	4 <script src="../inspector/console-test.js"></script>

	5 <script type="text/javascript">

	6 function onload()

	7 {

	8 if (window.testRunner)

	9 testRunner.waitUntilDone();

	10 setTimeout(showInspectorAndRunTest, 0);

	11

	12 var scriptContents = "function foo() { FAIL.FAIL; } \n //# sourceURL=foo2.js ";

	13 eval(scriptContents);

	14 foo();

	15 //# sourceURL=outer_src
	vsevik 2014/04/30 15:16:59 I don't think this is needed here (inline script u I don't think this is needed here (inline script url will be implicitly set to the document url). Also adding sourceURL comment in the middle is not correct accroding to the sourceURL spec (it might work correctly though). kozyatinskiy1 2014/04/30 16:08:04 Done. Show quoted text On 2014/04/30 15:16:59, vsevik wrote: > I don't think this is needed here (inline script url will be implicitly set to > the document url). > Also adding sourceURL comment in the middle is not correct accroding to the > sourceURL spec (it might work correctly though). Done.
	16 }

	17

	18

	19 function showInspectorAndRunTest()

	20 {

	21 if (window.testRunner)

	22 testRunner.showWebInspector();

	23 runTest();

	24 }

	25

	26 function test()

	27 {

	28 InspectorTest.expandConsoleMessages();

	29 InspectorTest.dumpConsoleMessages();

	30 InspectorTest.addResult("TEST COMPLETE");

	31 InspectorTest.completeTest();

	32 }

	33 </script>

	34 </head>

	35 <body onload="onload()">

	36 <p>Tests that when exception happens before inspector is open source url is corr ectly shown in console.</p>

	37 </body>

	38 </html>

OLD	NEW