Source/bindings/v8/WorkerScriptController.cpp - Issue 260513004: DevTools: [Console] fix sourceurl when exception happens before inspector is open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/WorkerScriptController.cpp

Issue 260513004: DevTools: [Console] fix sourceurl when exception happens before inspector is open (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/WorkerScriptController.cpp

diff --git a/Source/bindings/v8/WorkerScriptController.cpp b/Source/bindings/v8/WorkerScriptController.cpp

index cb027bfee6b5d3889382c5e9c433856b2f4d5c4b..8cf2eb2743f2cf19c46dd118267a9a777ac7d5da 100644

--- a/Source/bindings/v8/WorkerScriptController.cpp

+++ b/Source/bindings/v8/WorkerScriptController.cpp

@@ -184,7 +184,7 @@ ScriptValue WorkerScriptController::evaluate(const String& script, const String&

state->errorMessage = toCoreString(message->Get());

state->lineNumber = message->GetLineNumber();

state->columnNumber = message->GetStartColumn() + 1;

- TOSTRING_DEFAULT(V8StringResource<>, sourceURL, message->GetScriptResourceName(), ScriptValue());

+ TOSTRING_DEFAULT(V8StringResource<>, sourceURL, message->GetScriptOrigin().ResourceName(), ScriptValue());

state->sourceURL = sourceURL;

state->exception = ScriptValue(m_scriptState.get(), block.Exception());

block.Reset();

« no previous file with comments | « Source/bindings/v8/V8Initializer.cpp ('k') | no next file » | no next file with comments »