Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2605073002: [turbofan] Do not generate unnecessary moves when casting a tagged value to a word. (Closed)

Created:
3 years, 11 months ago by epertoso
Modified:
3 years, 11 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Do not generate unnecessary moves when casting a tagged value to a word. We currently use BitcastTaggedToWord only in from the code assemblers to verify the correctness of the operation. BUG= Review-Url: https://codereview.chromium.org/2605073002 Cr-Commit-Position: refs/heads/master@{#41979} Committed: https://chromium.googlesource.com/v8/v8/+/6f62fd3d83bda3ec9378b424809e0fac03507138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/compiler/instruction-selector.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
epertoso
3 years, 11 months ago (2016-12-28 16:55:24 UTC) #2
danno
lgtm
3 years, 11 months ago (2016-12-28 17:00:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605073002/1
3 years, 11 months ago (2016-12-28 17:25:11 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2016-12-28 17:26:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6f62fd3d83bda3ec9378b424809e0fac035...

Powered by Google App Engine
This is Rietveld 408576698