Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Side by Side Diff: src/compiler/instruction-selector.cc

Issue 2605073002: [turbofan] Do not generate unnecessary moves when casting a tagged value to a word. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/instruction-selector.h" 5 #include "src/compiler/instruction-selector.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/base/adapters.h" 9 #include "src/base/adapters.h"
10 #include "src/compiler/compiler-source-position-table.h" 10 #include "src/compiler/compiler-source-position-table.h"
(...skipping 1618 matching lines...) Expand 10 before | Expand all | Expand 10 after
1629 void InstructionSelector::VisitStackSlot(Node* node) { 1629 void InstructionSelector::VisitStackSlot(Node* node) {
1630 int size = 1 << ElementSizeLog2Of(StackSlotRepresentationOf(node->op())); 1630 int size = 1 << ElementSizeLog2Of(StackSlotRepresentationOf(node->op()));
1631 int slot = frame_->AllocateSpillSlot(size); 1631 int slot = frame_->AllocateSpillSlot(size);
1632 OperandGenerator g(this); 1632 OperandGenerator g(this);
1633 1633
1634 Emit(kArchStackSlot, g.DefineAsRegister(node), 1634 Emit(kArchStackSlot, g.DefineAsRegister(node),
1635 sequence()->AddImmediate(Constant(slot)), 0, nullptr); 1635 sequence()->AddImmediate(Constant(slot)), 0, nullptr);
1636 } 1636 }
1637 1637
1638 void InstructionSelector::VisitBitcastTaggedToWord(Node* node) { 1638 void InstructionSelector::VisitBitcastTaggedToWord(Node* node) {
1639 OperandGenerator g(this); 1639 EmitIdentity(node);
1640 Emit(kArchNop, g.DefineSameAsFirst(node), g.Use(node->InputAt(0)));
1641 } 1640 }
1642 1641
1643 void InstructionSelector::VisitBitcastWordToTagged(Node* node) { 1642 void InstructionSelector::VisitBitcastWordToTagged(Node* node) {
1644 OperandGenerator g(this); 1643 OperandGenerator g(this);
1645 Emit(kArchNop, g.DefineSameAsFirst(node), g.Use(node->InputAt(0))); 1644 Emit(kArchNop, g.DefineSameAsFirst(node), g.Use(node->InputAt(0)));
1646 } 1645 }
1647 1646
1648 // 32 bit targets do not implement the following instructions. 1647 // 32 bit targets do not implement the following instructions.
1649 #if V8_TARGET_ARCH_32_BIT 1648 #if V8_TARGET_ARCH_32_BIT
1650 1649
(...skipping 606 matching lines...) Expand 10 before | Expand all | Expand 10 after
2257 return new (instruction_zone()) FrameStateDescriptor( 2256 return new (instruction_zone()) FrameStateDescriptor(
2258 instruction_zone(), state_info.type(), state_info.bailout_id(), 2257 instruction_zone(), state_info.type(), state_info.bailout_id(),
2259 state_info.state_combine(), parameters, locals, stack, 2258 state_info.state_combine(), parameters, locals, stack,
2260 state_info.shared_info(), outer_state); 2259 state_info.shared_info(), outer_state);
2261 } 2260 }
2262 2261
2263 2262
2264 } // namespace compiler 2263 } // namespace compiler
2265 } // namespace internal 2264 } // namespace internal
2266 } // namespace v8 2265 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698