Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Issue 2605063002: S390: Fix fast-allocate to handle alignment (Closed)

Created:
3 years, 11 months ago by JoranSiu
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix fast-allocate to handle alignment In fast-allocate, the path that leverages Add Mem-Imm fails to take into account that the allocation size may be adjusted by kDoubleSize/2 for alignment. Limit this instruction to 64-bit only. Also guard PFDs with the proper facility check. R=jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2605063002 Cr-Commit-Position: refs/heads/master@{#41978} Committed: https://chromium.googlesource.com/v8/v8/+/e0f97ebb32d3bd3f5f94927f81717e7ee8b0a7d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -17 lines) Patch
M src/s390/macro-assembler-s390.cc View 4 chunks +33 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
JoranSiu
ptal
3 years, 11 months ago (2016-12-28 16:46:17 UTC) #3
JaideepBajwa
lgtm
3 years, 11 months ago (2016-12-28 17:01:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605063002/1
3 years, 11 months ago (2016-12-28 17:09:49 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2016-12-28 17:11:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e0f97ebb32d3bd3f5f94927f81717e7ee8b...

Powered by Google App Engine
This is Rietveld 408576698