Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2605003003: Rename provisionally_saved_form -> submitted_form. (Closed)

Created:
3 years, 11 months ago by dvadym
Modified:
3 years, 11 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename provisionally_saved_form -> submitted_form. In PasswordFormManager provisionally_saved_form is actually submitted form and it's very unclear from variable name. BUG=None Committed: https://crrev.com/e6c54408561d0475510859463da839907d733541 Cr-Commit-Position: refs/heads/master@{#440855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -67 lines) Patch
M components/password_manager/core/browser/password_form_manager.h View 4 chunks +5 lines, -5 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 14 chunks +45 lines, -56 lines 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dvadym
Hi Vaclav, Could you please review this CL? Regards, Vadym
3 years, 11 months ago (2016-12-28 14:05:10 UTC) #3
vabr (Chromium)
Thanks, LGTM! Vaclav
3 years, 11 months ago (2016-12-28 15:43:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605003003/1
3 years, 11 months ago (2016-12-28 16:50:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-28 16:54:04 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:49:12 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6c54408561d0475510859463da839907d733541
Cr-Commit-Position: refs/heads/master@{#440855}

Powered by Google App Engine
This is Rietveld 408576698