Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 2605003003: Rename provisionally_saved_form -> submitted_form. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_form_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index dae39509e4784c5a57a1be4da5e45ef788fc86ff..dc06e20c4e8d73bb9c0a8fd03124d6a5b86714f6 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -333,11 +333,11 @@ void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
manager.swap(*matched_manager_it);
pending_login_managers_.erase(matched_manager_it);
- PasswordForm provisionally_saved_form(form);
- provisionally_saved_form.preferred = true;
+ PasswordForm submitted_form(form);
+ submitted_form.preferred = true;
if (logger) {
logger->LogPasswordForm(Logger::STRING_PROVISIONALLY_SAVED_FORM,
- provisionally_saved_form);
+ submitted_form);
}
PasswordFormManager::OtherPossibleUsernamesAction action =
PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES;
@@ -348,7 +348,7 @@ void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
Logger::STRING_IGNORE_POSSIBLE_USERNAMES,
action == PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);
}
- manager->ProvisionallySave(provisionally_saved_form, action);
+ manager->ProvisionallySave(submitted_form, action);
provisional_save_manager_.swap(manager);
// Cache the user-visible URL (i.e., the one seen in the omnibox). Once the
@@ -678,9 +678,9 @@ void PasswordManager::OnLoginSuccessful() {
*provisional_save_manager_);
if (base::FeatureList::IsEnabled(features::kDropSyncCredential)) {
- DCHECK(provisional_save_manager_->provisionally_saved_form());
+ DCHECK(provisional_save_manager_->submitted_form());
if (!client_->GetStoreResultFilter()->ShouldSave(
- *provisional_save_manager_->provisionally_saved_form())) {
+ *provisional_save_manager_->submitted_form())) {
provisional_save_manager_->WipeStoreCopyIfOutdated();
RecordFailure(SYNC_CREDENTIAL,
provisional_save_manager_->observed_form().origin,
« no previous file with comments | « components/password_manager/core/browser/password_form_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698