Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2604113002: Remove mojo::WTFArray. (Closed)

Created:
3 years, 11 months ago by Sam McNally
Modified:
3 years, 11 months ago
Reviewers:
haraken, yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, gogerald+paymentswatch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, rouslan+payments_chromium.org, blink-reviews, kinuko+watch, darin (slow to review), sebsg+paymentswatch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mojo::WTFArray. BUG=674766 Review-Url: https://codereview.chromium.org/2604113002 Cr-Commit-Position: refs/heads/master@{#442513} Committed: https://chromium.googlesource.com/chromium/src/+/5f30381b94d78a16411f34aafb34524c97ff800b

Patch Set 1 : #

Total comments: 6

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -356 lines) Patch
M mojo/public/cpp/bindings/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D mojo/public/cpp/bindings/array_traits_wtf.h View 1 chunk +0 lines, -40 lines 0 comments Download
M mojo/public/cpp/bindings/lib/wtf_serialization.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/struct_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/public/cpp/bindings/tests/wtf_array_unittest.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M mojo/public/cpp/bindings/tests/wtf_types_unittest.cc View 1 2 3 chunks +7 lines, -28 lines 0 comments Download
D mojo/public/cpp/bindings/wtf_array.h View 1 chunk +0 lines, -197 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 1 2 3 4 6 chunks +22 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mojo/DEPS View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2604953003 Patch 200001

Dependent Patchsets:

Issue 2607063002 Patch 140001
Issue 2607063002 Patch 180001
Issue 2607063002 Patch 200001

Messages

Total messages: 39 (30 generated)
Sam McNally
3 years, 11 months ago (2016-12-29 06:35:38 UTC) #16
haraken
https://codereview.chromium.org/2604113002/diff/80001/third_party/WebKit/Source/modules/nfc/NFC.cpp File third_party/WebKit/Source/modules/nfc/NFC.cpp (right): https://codereview.chromium.org/2604113002/diff/80001/third_party/WebKit/Source/modules/nfc/NFC.cpp#newcode242 third_party/WebKit/Source/modules/nfc/NFC.cpp:242: mojo::ConvertTo<WTF::Optional<WTF::Vector<uint8_t>>>(record.data()); Why do we need Optional? Maybe can we ...
3 years, 11 months ago (2016-12-29 11:42:36 UTC) #20
Sam McNally
https://codereview.chromium.org/2604113002/diff/80001/third_party/WebKit/Source/modules/nfc/NFC.cpp File third_party/WebKit/Source/modules/nfc/NFC.cpp (right): https://codereview.chromium.org/2604113002/diff/80001/third_party/WebKit/Source/modules/nfc/NFC.cpp#newcode242 third_party/WebKit/Source/modules/nfc/NFC.cpp:242: mojo::ConvertTo<WTF::Optional<WTF::Vector<uint8_t>>>(record.data()); On 2016/12/29 11:42:35, haraken wrote: > > Why ...
3 years, 11 months ago (2016-12-30 00:21:14 UTC) #21
haraken
WebKit LGTM
3 years, 11 months ago (2016-12-30 00:22:11 UTC) #22
yzshen1
LGTM with two nits https://codereview.chromium.org/2604113002/diff/80001/third_party/WebKit/Source/modules/nfc/NFC.cpp File third_party/WebKit/Source/modules/nfc/NFC.cpp (right): https://codereview.chromium.org/2604113002/diff/80001/third_party/WebKit/Source/modules/nfc/NFC.cpp#newcode128 third_party/WebKit/Source/modules/nfc/NFC.cpp:128: return WTF::Vector<uint8_t>(std::move(array)); you could return ...
3 years, 11 months ago (2017-01-03 21:33:28 UTC) #23
Sam McNally
https://codereview.chromium.org/2604113002/diff/80001/third_party/WebKit/Source/modules/nfc/NFC.cpp File third_party/WebKit/Source/modules/nfc/NFC.cpp (right): https://codereview.chromium.org/2604113002/diff/80001/third_party/WebKit/Source/modules/nfc/NFC.cpp#newcode128 third_party/WebKit/Source/modules/nfc/NFC.cpp:128: return WTF::Vector<uint8_t>(std::move(array)); On 2017/01/03 21:33:28, yzshen1 wrote: > you ...
3 years, 11 months ago (2017-01-04 00:30:17 UTC) #26
yzshen1
lgtm
3 years, 11 months ago (2017-01-04 00:31:57 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604113002/160001
3 years, 11 months ago (2017-01-10 02:03:47 UTC) #36
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 06:14:42 UTC) #39
Message was sent while issue was closed. 
Committed patchset #5 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/5f30381b94d78a16411f34aafb34...

Powered by Google App Engine
This is Rietveld 408576698