Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2605893002: [builtins] More stubs to the builtin-o-sphere. (Closed)

Created:
3 years, 11 months ago by mvstanton
Modified:
3 years, 11 months ago
Reviewers:
rmcilroy, *danno
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] More stubs to the builtin-o-sphere. The following ported to builtins: FastCloneRegExp FastCloneShallowArray FastCloneShallowObject BUG= TBR=rmcilroy@chromium.org, rossberg@chromium.org Review-Url: https://codereview.chromium.org/2605893002 Cr-Commit-Position: refs/heads/master@{#41989} Committed: https://chromium.googlesource.com/v8/v8/+/05873add8516d40547dc3976ba9748fa3d8f9bac

Patch Set 1 #

Patch Set 2 : REBASE. #

Patch Set 3 : Added FastCloneShallowObject. #

Patch Set 4 : REBASE. #

Patch Set 5 : Removes underscores. #

Patch Set 6 : Fixed compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+518 lines, -507 lines) Patch
M src/ast/ast.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/ast/ast.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M src/builtins/builtins.h View 1 2 3 4 2 chunks +21 lines, -0 lines 0 comments Download
M src/builtins/builtins-constructor.h View 1 2 2 chunks +28 lines, -0 lines 0 comments Download
M src/builtins/builtins-constructor.cc View 1 2 3 4 2 chunks +382 lines, -0 lines 0 comments Download
M src/code-factory.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 2 3 1 chunk +8 lines, -9 lines 0 comments Download
M src/code-stubs.h View 1 2 3 2 chunks +0 lines, -78 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 2 chunks +0 lines, -363 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 2 chunks +9 lines, -6 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 4 5 2 chunks +6 lines, -4 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 4 5 2 chunks +6 lines, -4 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 4 5 2 chunks +6 lines, -4 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 4 5 2 chunks +6 lines, -4 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 3 4 5 2 chunks +6 lines, -4 lines 0 comments Download
M src/globals.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-flags.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 2 3 3 chunks +9 lines, -7 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
mvstanton
HI Danno, Here are some lunch...
3 years, 11 months ago (2016-12-29 11:49:39 UTC) #4
danno
Nice lunch. LGTM with renames TBD after I land the TF_BUILTIN macro fix.
3 years, 11 months ago (2016-12-29 12:47:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605893002/100001
3 years, 11 months ago (2016-12-29 12:50:28 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/v8/v8/+/05873add8516d40547dc3976ba9748fa3d8f9bac
3 years, 11 months ago (2016-12-29 13:02:14 UTC) #17
rmcilroy
3 years, 11 months ago (2017-01-03 09:24:02 UTC) #18
Message was sent while issue was closed.
Belated LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698