Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2604833003: Revert of Tab (and AuraWindow) Capture: Capture refresh frame after Resume() (Closed)

Created:
3 years, 12 months ago by cmumford
Modified:
3 years, 11 months ago
Reviewers:
xjz, miu
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Tab (and AuraWindow) Capture: Capture refresh frame after Resume() (patchset #2 id:20001 of https://codereview.chromium.org/2603533002/ ) Reason for revert: Speculative revert because WebContentsVideoCaptureDeviceTest.StopWithRendererWorkToDo is crashing with media::ThreadSafeCaptureOracle calling CopyRGBToVideoFrame. https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/56009 Original issue's description: > Tab (and AuraWindow) Capture: Capture refresh frame after Resume() > > Adds a refresh frame capture upon Resume(). This solves a problem where > the tab capture device can be suspended for a significant length of time > and then resumed; but if the content of the tab isn't changing when the > resume takes place, no compositor events will be firing to cause any new > frames to be captured. Thus, the content in the video stream could be > very stale. Issuing a refresh frame capture guarantees the video stream > will be up-to-date immediately after a resume. > > BUG=643964 > > Review-Url: https://codereview.chromium.org/2603533002 TBR=xjz@chromium.org,miu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=643964 Committed: https://crrev.com/4573aaf76ac901bd48fc2eaa5314a206a04a6cc5 Cr-Commit-Position: refs/heads/master@{#440810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M content/browser/media/capture/aura_window_capture_machine.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
cmumford
Created Revert of Tab (and AuraWindow) Capture: Capture refresh frame after Resume()
3 years, 12 months ago (2016-12-27 23:56:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604833003/1
3 years, 12 months ago (2016-12-27 23:57:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-27 23:58:06 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:47:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4573aaf76ac901bd48fc2eaa5314a206a04a6cc5
Cr-Commit-Position: refs/heads/master@{#440810}

Powered by Google App Engine
This is Rietveld 408576698