Tab (and AuraWindow) Capture: Capture refresh frame after Resume()

Tab (and AuraWindow) Capture: Capture refresh frame after Resume()

Adds a refresh frame capture upon Resume(). This solves a problem where
the tab capture device can be suspended for a significant length of time
and then resumed; but if the content of the tab isn't changing when the
resume takes place, no compositor events will be firing to cause any new
frames to be captured. Thus, the content in the video stream could be
very stale. Issuing a refresh frame capture guarantees the video stream
will be up-to-date immediately after a resume.

BUG=643964
Committed: https://crrev.com/0a1661e31160d9dd7c020383702fad19e0d12e54
Cr-Commit-Position: refs/heads/master@{#440792}

[miu, 2016-12-22 23:49:39]

miu@chromium.org changed reviewers:
+ xjz@chromium.org

[miu, 2016-12-22 23:49:39]

xjz: PTAL.

[xjz, 2016-12-23 00:13:58]

lgtm

[miu, 2016-12-23 00:28:57]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2016-12-23 00:29:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 00:58:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 00:58:06]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[miu, 2016-12-27 21:10:59]

The CQ bit was checked by miu@chromium.org

[miu, 2016-12-27 21:11:00]

The patchset sent to the CQ was uploaded after l-g-t-m from xjz@chromium.org
Link to the patchset: https://codereview.chromium.org/2603533002/#ps20001
(title: "Account for behavior change in unit tests.")

[commit-bot: I haz the power, 2016-12-27 21:11:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 21:53:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482873059807870,
"parent_rev": "3bac61e1436f4125f2fec4622dbc5157fd865553", "commit_rev":
"c394fa5cdbffb5423effc7a27a3e2c4d08521f39"}

[commit-bot: I haz the power, 2016-12-27 21:54:25]

Description was changed from

==========
Tab (and AuraWindow) Capture: Capture refresh frame after Resume()

Adds a refresh frame capture upon Resume(). This solves a problem where
the tab capture device can be suspended for a significant length of time
and then resumed; but if the content of the tab isn't changing when the
resume takes place, no compositor events will be firing to cause any new
frames to be captured. Thus, the content in the video stream could be
very stale. Issuing a refresh frame capture guarantees the video stream
will be up-to-date immediately after a resume.

BUG=643964
==========

to

==========
Tab (and AuraWindow) Capture: Capture refresh frame after Resume()

Adds a refresh frame capture upon Resume(). This solves a problem where
the tab capture device can be suspended for a significant length of time
and then resumed; but if the content of the tab isn't changing when the
resume takes place, no compositor events will be firing to cause any new
frames to be captured. Thus, the content in the video stream could be
very stale. Issuing a refresh frame capture guarantees the video stream
will be up-to-date immediately after a resume.

BUG=643964

Review-Url: https://codereview.chromium.org/2603533002
==========

[commit-bot: I haz the power, 2016-12-27 21:54:26]

Committed patchset #2 (id:20001)

[cmumford, 2016-12-27 23:56:49]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2604833003/ by cmumford@chromium.org.

The reason for reverting is: Speculative revert because
WebContentsVideoCaptureDeviceTest.StopWithRendererWorkToDo is crashing with
media::ThreadSafeCaptureOracle calling CopyRGBToVideoFrame.

https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%....

[commit-bot: I haz the power, 2017-01-02 15:47:23]

Description was changed from

==========
Tab (and AuraWindow) Capture: Capture refresh frame after Resume()

Adds a refresh frame capture upon Resume(). This solves a problem where
the tab capture device can be suspended for a significant length of time
and then resumed; but if the content of the tab isn't changing when the
resume takes place, no compositor events will be firing to cause any new
frames to be captured. Thus, the content in the video stream could be
very stale. Issuing a refresh frame capture guarantees the video stream
will be up-to-date immediately after a resume.

BUG=643964

Review-Url: https://codereview.chromium.org/2603533002
==========

to

==========
Tab (and AuraWindow) Capture: Capture refresh frame after Resume()

Adds a refresh frame capture upon Resume(). This solves a problem where
the tab capture device can be suspended for a significant length of time
and then resumed; but if the content of the tab isn't changing when the
resume takes place, no compositor events will be firing to cause any new
frames to be captured. Thus, the content in the video stream could be
very stale. Issuing a refresh frame capture guarantees the video stream
will be up-to-date immediately after a resume.

BUG=643964

Committed: https://crrev.com/0a1661e31160d9dd7c020383702fad19e0d12e54
Cr-Commit-Position: refs/heads/master@{#440792}
==========

[commit-bot: I haz the power, 2017-01-02 15:47:24]

Patchset 2 (id:??) landed as
https://crrev.com/0a1661e31160d9dd7c020383702fad19e0d12e54
Cr-Commit-Position: refs/heads/master@{#440792}