Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2604763003: [ios] Cleaned up comments and tests for CookieStoreIOS synchronization. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Cleaned up comments and tests for CookieStoreIOS synchronization. In UIWebView world CookieStoreIOS could dynamically change its state and either be synchronized with NSHTTPCookieStorage or unsynchronized. In WKWebView world CookieStoreIOS never changes its state. It is either always synchronized (for sign in) or always unsynchronized (for regular browsing). Notable changes: - updated comments to reflect that sync state is not dynamic - removed RoundTripTest which tested non-existing dynamic synchronization flow - removed other tests which tests dynamic synchronization BUG=676144 Committed: https://crrev.com/d649da83761a5469b5d8b8a294682128ccfcbdee Cr-Commit-Position: refs/heads/master@{#440851}

Patch Set 1 #

Patch Set 2 : Removed more obsoleted tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -249 lines) Patch
M ios/net/cookies/cookie_store_ios.h View 1 chunk +8 lines, -16 lines 0 comments Download
M ios/net/cookies/cookie_store_ios_unittest.mm View 1 3 chunks +0 lines, -233 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2016-12-28 02:50:38 UTC) #7
marq (ping after 24h)
lgtm
3 years, 11 months ago (2016-12-28 09:40:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604763003/20001
3 years, 11 months ago (2016-12-28 16:36:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2016-12-28 16:40:24 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:49:04 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d649da83761a5469b5d8b8a294682128ccfcbdee
Cr-Commit-Position: refs/heads/master@{#440851}

Powered by Google App Engine
This is Rietveld 408576698