Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: ios/net/cookies/cookie_store_ios.h

Issue 2604763003: [ios] Cleaned up comments and tests for CookieStoreIOS synchronization. (Closed)
Patch Set: Removed more obsoleted tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/net/cookies/cookie_store_ios_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/net/cookies/cookie_store_ios.h
diff --git a/ios/net/cookies/cookie_store_ios.h b/ios/net/cookies/cookie_store_ios.h
index 6d37364c29225d5b386c18e5c9bee52098580814..2c8218f1c612aef990e2ac5d2480fd025423719f 100644
--- a/ios/net/cookies/cookie_store_ios.h
+++ b/ios/net/cookies/cookie_store_ios.h
@@ -41,24 +41,16 @@ class CookieNotificationObserver {
// The CookieStoreIOS is an implementation of CookieStore relying on
// NSHTTPCookieStorage, ensuring that the cookies are consistent between the
-// network stack and the UIWebViews.
-// On iOS, the Chrome CookieMonster is not used in conjunction with UIWebView,
-// because UIWebView expects the cookies to be in the shared
-// NSHTTPCookieStorage. In particular, javascript may read and write cookies
-// there.
+// network stack and NSHTTPCookieStorage.
// CookieStoreIOS is not thread safe.
//
-// At any given time, a CookieStoreIOS can either be synchronized with the
-// system cookie store or not. If a CookieStoreIOS is not synchronized with the
-// system store, changes are written back to the backing CookieStore. If a
-// CookieStoreIOS is synchronized with the system store, changes are written
-// directly to the system cookie store, then propagated to the backing store by
-// OnSystemCookiesChanged, which is called by the system store once the change
-// to the system store is written back.
-//
-// To unsynchronize, CookieStoreIOS copies the system cookie store into its
-// backing CookieStore. To synchronize, CookieStoreIOS clears the system cookie
-// store, copies its backing CookieStore into the system cookie store.
+// CookieStoreIOS can be created synchronized with the system cookie store (via
+// CreateCookieStore) or not (other constructors). If a CookieStoreIOS is not
+// synchronized with the system store, changes are written back to the backing
+// CookieStore. If a CookieStoreIOS is synchronized with the system store,
+// changes are written directly to the system cookie store, then propagated to
+// the backing store by OnSystemCookiesChanged, which is called by the system
+// store once the change to the system store is written back.
class CookieStoreIOS : public net::CookieStore,
public CookieNotificationObserver {
public:
« no previous file with comments | « no previous file | ios/net/cookies/cookie_store_ios_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698