Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2604683002: Remove ASSERT_NOT_REACHED() in audio. (Closed)

Created:
3 years, 12 months ago by haeun
Modified:
3 years, 11 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews, kinuko+watch, Raymond Toy, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ASSERT_NOT_REACHED() in audio. BUG=596760 Committed: https://crrev.com/035d765e4615281404fc7b611b2095286fdda76d Cr-Commit-Position: refs/heads/master@{#441610}

Patch Set 1 #

Patch Set 2 : Add AUTHORS. #

Patch Set 3 : fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioBus.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/Distance.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/DynamicsCompressor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/FFTFrameStub.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/Panner.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (15 generated)
haeun
junov@ For reviewer, I already signed Google CLA. PTAL.
3 years, 12 months ago (2016-12-24 14:59:55 UTC) #3
Justin Novosad
lgtm Sorry about the delay, I was out of the office.
3 years, 11 months ago (2017-01-04 20:43:19 UTC) #4
haeun
On 2017/01/04 20:43:19, Justin Novosad wrote: > lgtm > > Sorry about the delay, I ...
3 years, 11 months ago (2017-01-04 21:12:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604683002/40001
3 years, 11 months ago (2017-01-05 08:17:05 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2017-01-05 08:21:20 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 08:25:16 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/035d765e4615281404fc7b611b2095286fdda76d
Cr-Commit-Position: refs/heads/master@{#441610}

Powered by Google App Engine
This is Rietveld 408576698