Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Unified Diff: third_party/WebKit/Source/platform/audio/AudioBus.cpp

Issue 2604683002: Remove ASSERT_NOT_REACHED() in audio. (Closed)
Patch Set: fixed. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/audio/AudioBus.cpp
diff --git a/third_party/WebKit/Source/platform/audio/AudioBus.cpp b/third_party/WebKit/Source/platform/audio/AudioBus.cpp
index 8fc9784ae9061a3e28e841f36c9fc17c904a37e4..1a520b746788650a02f46dd2e804d4f63ad57e4d 100644
--- a/third_party/WebKit/Source/platform/audio/AudioBus.cpp
+++ b/third_party/WebKit/Source/platform/audio/AudioBus.cpp
@@ -163,7 +163,7 @@ AudioChannel* AudioBus::channelByType(unsigned channelType) {
}
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
}
@@ -467,7 +467,7 @@ void AudioBus::copyWithGainFrom(const AudioBus& sourceBus,
float* lastMixGain,
float targetGain) {
if (!topologyMatches(sourceBus)) {
- ASSERT_NOT_REACHED();
+ NOTREACHED();
zero();
return;
}
@@ -583,12 +583,12 @@ void AudioBus::copyWithSampleAccurateGainValuesFrom(
// Make sure we're processing from the same type of bus.
// We *are* able to process from mono -> stereo
if (sourceBus.numberOfChannels() != 1 && !topologyMatches(sourceBus)) {
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return;
}
if (!gainValues || numberOfGainValues > sourceBus.length()) {
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return;
}
@@ -702,7 +702,7 @@ PassRefPtr<AudioBus> AudioBus::createByMixingToMono(const AudioBus* sourceBus) {
}
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
}
« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698