Description was changed from ========== [Sensors] Reland: Reland: Align sensor reading updates and 'onchange' notification ...
3 years, 12 months ago
(2016-12-23 13:48:45 UTC)
#2
Description was changed from
==========
[Sensors] Reland: Reland: Align sensor reading updates and 'onchange'
notification with rAF.
For all sensors new reading values are read and 'onchange' notfication is send
from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.
Before this change a timers were used and this could unnecessarily drain CPU and
battery.
BUG=668052
BUG=606766
Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb
Cr-Commit-Position: refs/heads/master@{#439467}
patch from issue 2551223003 at patchset 140001
(http://crrev.com/2551223003#ps140001)
Committed: https://crrev.com/5f2cde61f6ff4a764b9b1c7d74a24ef6de815835
Cr-Commit-Position: refs/heads/master@{#440208}
patch from issue 2589283003 at patchset 60001
(http://crrev.com/2589283003#ps60001)
==========
to
==========
[Sensors] Reland: Reland: Align sensor reading updates and 'onchange'
notification with rAF.
For all sensors new reading values are read and 'onchange' notfication is send
from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.
Before this change a timers were used and this could unnecessarily drain CPU and
battery.
BUG=668052
BUG=606766
Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb
Cr-Commit-Position: refs/heads/master@{#439467}
patch from issue 2551223003 at patchset 140001
(http://crrev.com/2551223003#ps140001)
Committed: https://crrev.com/5f2cde61f6ff4a764b9b1c7d74a24ef6de815835
Cr-Commit-Position: refs/heads/master@{#440208}
patch from issue 2589283003 at patchset 60001
(http://crrev.com/2589283003#ps60001)
==========
So the problem this time was a stupid leftover (pls see https://codereview.chromium.org/2604483004/diff2/1:20001/third_party/WebKit/Source/modules/sensor/SensorReadingUpdater.h). Would be nice ...
3 years, 12 months ago
(2016-12-23 13:51:28 UTC)
#5
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482519285067640, "parent_rev": "afb7eeae3a2d76ad4dfaa24f5dedec156f3a864e", "commit_rev": "78a008f3728df1535c3f312695bb32aa5ff35c16"}
3 years, 12 months ago
(2016-12-23 18:58:23 UTC)
#11
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482519285067640,
"parent_rev": "afb7eeae3a2d76ad4dfaa24f5dedec156f3a864e", "commit_rev":
"78a008f3728df1535c3f312695bb32aa5ff35c16"}
commit-bot: I haz the power
Description was changed from ========== [Sensors] Reland: Reland: Align sensor reading updates and 'onchange' notification ...
3 years, 12 months ago
(2016-12-23 18:58:56 UTC)
#12
Message was sent while issue was closed.
Description was changed from
==========
[Sensors] Reland: Reland: Align sensor reading updates and 'onchange'
notification with rAF.
For all sensors new reading values are read and 'onchange' notfication is send
from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.
Before this change a timers were used and this could unnecessarily drain CPU and
battery.
BUG=668052
BUG=606766
Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb
Cr-Commit-Position: refs/heads/master@{#439467}
patch from issue 2551223003 at patchset 140001
(http://crrev.com/2551223003#ps140001)
Committed: https://crrev.com/5f2cde61f6ff4a764b9b1c7d74a24ef6de815835
Cr-Commit-Position: refs/heads/master@{#440208}
patch from issue 2589283003 at patchset 60001
(http://crrev.com/2589283003#ps60001)
==========
to
==========
[Sensors] Reland: Reland: Align sensor reading updates and 'onchange'
notification with rAF.
For all sensors new reading values are read and 'onchange' notfication is send
from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.
Before this change a timers were used and this could unnecessarily drain CPU and
battery.
BUG=668052
BUG=606766
Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb
Cr-Commit-Position: refs/heads/master@{#439467}
patch from issue 2551223003 at patchset 140001
(http://crrev.com/2551223003#ps140001)
Committed: https://crrev.com/5f2cde61f6ff4a764b9b1c7d74a24ef6de815835
Cr-Commit-Position: refs/heads/master@{#440208}
patch from issue 2589283003 at patchset 60001
(http://crrev.com/2589283003#ps60001)
Review-Url: https://codereview.chromium.org/2604483004
==========
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago
(2016-12-23 18:58:57 UTC)
#13
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
commit-bot: I haz the power
Description was changed from ========== [Sensors] Reland: Reland: Align sensor reading updates and 'onchange' notification ...
3 years, 12 months ago
(2016-12-23 19:01:01 UTC)
#14
Issue 2604483004: [Sensors] Reland: Reland: Align sensor reading updates and 'onchange' notification with rAF.
(Closed)
Created 3 years, 12 months ago by Mikhail
Modified 3 years, 12 months ago
Reviewers: shalamov, haraken, Reilly Grant (use Gerrit)
Base URL:
Comments: 0