Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2604483004: [Sensors] Reland: Reland: Align sensor reading updates and 'onchange' notification with rAF. (Closed)

Created:
3 years, 12 months ago by Mikhail
Modified:
3 years, 12 months ago
CC:
chromium-reviews, blink-reviews, wanming.lin, shalamov, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Reland: Reland: Align sensor reading updates and 'onchange' notification with rAF. For all sensors new reading values are read and 'onchange' notfication is send from rAF callbacks, thus avoiding possible Critical Rendering Path interruption. Before this change a timers were used and this could unnecessarily drain CPU and battery. BUG=668052 BUG=606766 Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb Cr-Commit-Position: refs/heads/master@{#439467} patch from issue 2551223003 at patchset 140001 (http://crrev.com/2551223003#ps140001) Committed: https://crrev.com/5f2cde61f6ff4a764b9b1c7d74a24ef6de815835 Cr-Commit-Position: refs/heads/master@{#440208} patch from issue 2589283003 at patchset 60001 (http://crrev.com/2589283003#ps60001) Committed: https://crrev.com/a14c24ea3dd1eb6c6bcb72d1ffa1b1cece4c3257 Cr-Commit-Position: refs/heads/master@{#440650}

Patch Set 1 : initial (reverted) patch #

Patch Set 2 : Patch with fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -256 lines) Patch
M third_party/WebKit/LayoutTests/sensor/accelerometer.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/gyroscope.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/magnetometer.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js View 4 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.h View 4 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 10 chunks +24 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProviderProxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.h View 7 chunks +24 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.cpp View 15 chunks +32 lines, -54 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/SensorReadingUpdater.h View 1 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/SensorReadingUpdater.cpp View 1 chunk +112 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/SensorUpdateNotificationStrategy.h View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/SensorUpdateNotificationStrategy.cpp View 1 chunk +0 lines, -85 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Mikhail
So the problem this time was a stupid leftover (pls see https://codereview.chromium.org/2604483004/diff2/1:20001/third_party/WebKit/Source/modules/sensor/SensorReadingUpdater.h). Would be nice ...
3 years, 12 months ago (2016-12-23 13:51:28 UTC) #5
haraken
LGTM
3 years, 12 months ago (2016-12-23 14:14:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604483004/20001
3 years, 12 months ago (2016-12-23 18:54:50 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-23 18:58:57 UTC) #13
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 19:01:03 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a14c24ea3dd1eb6c6bcb72d1ffa1b1cece4c3257
Cr-Commit-Position: refs/heads/master@{#440650}

Powered by Google App Engine
This is Rietveld 408576698