Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: third_party/WebKit/LayoutTests/sensor/accelerometer.html

Issue 2604483004: [Sensors] Reland: Reland: Align sensor reading updates and 'onchange' notification with rAF. (Closed)
Patch Set: Patch with fix Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <script src="../resources/testharness.js"></script> 2 <script src="../resources/testharness.js"></script>
3 <script src="../resources/testharnessreport.js"></script> 3 <script src="../resources/testharnessreport.js"></script>
4 <script src="../resources/mojo-helpers.js"></script> 4 <script src="../resources/mojo-helpers.js"></script>
5 <script src="resources/sensor-helpers.js"></script> 5 <script src="resources/sensor-helpers.js"></script>
6 <script src="resources/generic-sensor-tests.js"></script> 6 <script src="resources/generic-sensor-tests.js"></script>
7 <script> 7 <script>
8 8
9 'use strict'; 9 'use strict';
10 10
11 if (!window.testRunner) 11 if (!window.testRunner)
12 debug('This test cannot be run without the TestRunner'); 12 debug('This test cannot be run without the TestRunner');
13 13
14 const kDefaultReadingX = 1.12345; 14 const kDefaultReadingX = 1.12345;
15 const kDefaultReadingY = 2.12345; 15 const kDefaultReadingY = 2.12345;
16 const kDefaultReadingZ = 3.12345; 16 const kDefaultReadingZ = 3.12345;
17 var readsCount = 0;
18 17
19 function update_sensor_reading(buffer, expects_modified_reading) { 18 function update_sensor_reading(buffer, expects_modified_reading, readsCount) {
20 buffer[1] = window.performance.now(); 19 buffer[1] = window.performance.now();
21 buffer[2] = kDefaultReadingX; 20 buffer[2] = kDefaultReadingX;
22 buffer[3] = kDefaultReadingY; 21 buffer[3] = kDefaultReadingY;
23 buffer[4] = kDefaultReadingZ; 22 buffer[4] = kDefaultReadingZ;
24 if (expects_modified_reading) 23 if (expects_modified_reading)
25 buffer[2] += readsCount; 24 buffer[2] += readsCount;
26
27 readsCount++;
28 } 25 }
29 26
30 function verify_sensor_reading(reading) { 27 function verify_sensor_reading(reading) {
31 return reading.x == kDefaultReadingX && 28 return reading.x == kDefaultReadingX &&
32 reading.y == kDefaultReadingY && 29 reading.y == kDefaultReadingY &&
33 reading.z == kDefaultReadingZ; 30 reading.z == kDefaultReadingZ;
34 } 31 }
35 32
36 runGenericSensorTests(Accelerometer, update_sensor_reading, verify_sensor_readin g); 33 runGenericSensorTests(Accelerometer, update_sensor_reading, verify_sensor_readin g);
37 34
(...skipping 13 matching lines...) Expand all
51 accelerometer.onactivate = wrapper.callback; 48 accelerometer.onactivate = wrapper.callback;
52 accelerometer.onerror = reject; 49 accelerometer.onerror = reject;
53 }); 50 });
54 }) 51 })
55 .then(mockSensor => { return mockSensor.removeConfigurationCalled(); }); 52 .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
56 53
57 return testPromise; 54 return testPromise;
58 }, 'Test that sensor can be successfully created with sensor specific configurat ion parameter.'); 55 }, 'Test that sensor can be successfully created with sensor specific configurat ion parameter.');
59 56
60 </script> 57 </script>
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698