Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2604393002: [turbofan] Utilize maps from field type tracking to eliminate map checks. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Utilize maps from field type tracking to eliminate map checks. Hook up TurboFan with the existing field type tracking machinery to eliminate redundant map checks on the results of LoadField operators. The store side is already implemented in TurboFan for quite some time, this just adds the load part. R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2604393002 Cr-Commit-Position: refs/heads/master@{#42015} Committed: https://chromium.googlesource.com/v8/v8/+/589ecbfa85a7e1b3e80d85a6af2f3488009982bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -287 lines) Patch
M src/compiler/access-builder.cc View 27 chunks +231 lines, -228 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/js-global-object-specialization.cc View 6 chunks +24 lines, -14 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 4 chunks +14 lines, -2 lines 0 comments Download
M src/compiler/load-elimination.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M test/unittests/compiler/escape-analysis-unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M test/unittests/compiler/load-elimination-unittest.cc View 7 chunks +21 lines, -35 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-02 13:36:11 UTC) #1
Jarin
lgtm
3 years, 11 months ago (2017-01-02 18:38:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604393002/1
3 years, 11 months ago (2017-01-02 19:05:52 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 19:07:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/589ecbfa85a7e1b3e80d85a6af2f3488009...

Powered by Google App Engine
This is Rietveld 408576698