[turbofan] Utilize maps from field type tracking to eliminate map checks.

test/unittests/compiler/load-elimination-unittest.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/load-elimination.h"
 #include "src/compiler/access-builder.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/node.h"
 #include "src/compiler/simplified-operator.h"
 #include "test/unittests/compiler/graph-reducer-unittest.h"
@@ skipping 107 matching lines @@
   EXPECT_CALL(editor, ReplaceWithValue(load, value, store2, _));
   Reduction r = load_elimination.Reduce(load);
   ASSERT_TRUE(r.Changed());
   EXPECT_EQ(value, r.replacement());
 }
 
 TEST_F(LoadEliminationTest, LoadFieldAndLoadField) {
   Node* object = Parameter(Type::Any(), 0);
   Node* effect = graph()->start();
   Node* control = graph()->start();
-  FieldAccess const access = {kTaggedBase,
-                              kPointerSize,
-                              MaybeHandle<Name>(),
-                              Type::Any(),
-                              MachineType::AnyTagged(),
+  FieldAccess const access = {kTaggedBase,         kPointerSize,
+                              MaybeHandle<Name>(), MaybeHandle<Map>(),
+                              Type::Any(),         MachineType::AnyTagged(),
                               kNoWriteBarrier};
 
   StrictMock<MockAdvancedReducerEditor> editor;
   LoadElimination load_elimination(&editor, jsgraph(), zone());
 
   load_elimination.Reduce(graph()->start());
 
   Node* load1 = effect = graph()->NewNode(simplified()->LoadField(access),
                                           object, effect, control);
   load_elimination.Reduce(load1);
 
   Node* load2 = effect = graph()->NewNode(simplified()->LoadField(access),
                                           object, effect, control);
   EXPECT_CALL(editor, ReplaceWithValue(load2, load1, load1, _));
   Reduction r = load_elimination.Reduce(load2);
   ASSERT_TRUE(r.Changed());
   EXPECT_EQ(load1, r.replacement());
 }
 
 TEST_F(LoadEliminationTest, StoreFieldAndLoadField) {
   Node* object = Parameter(Type::Any(), 0);
   Node* value = Parameter(Type::Any(), 1);
   Node* effect = graph()->start();
   Node* control = graph()->start();
-  FieldAccess access = {kTaggedBase,
-                        kPointerSize,
-                        MaybeHandle<Name>(),
-                        Type::Any(),
-                        MachineType::AnyTagged(),
+  FieldAccess access = {kTaggedBase,         kPointerSize,
+                        MaybeHandle<Name>(), MaybeHandle<Map>(),
+                        Type::Any(),         MachineType::AnyTagged(),
                         kNoWriteBarrier};
 
   StrictMock<MockAdvancedReducerEditor> editor;
   LoadElimination load_elimination(&editor, jsgraph(), zone());
 
   load_elimination.Reduce(graph()->start());
 
   Node* store = effect = graph()->NewNode(simplified()->StoreField(access),
                                           object, value, effect, control);
   load_elimination.Reduce(store);
 
   Node* load = effect = graph()->NewNode(simplified()->LoadField(access),
                                          object, effect, control);
   EXPECT_CALL(editor, ReplaceWithValue(load, value, store, _));
   Reduction r = load_elimination.Reduce(load);
   ASSERT_TRUE(r.Changed());
   EXPECT_EQ(value, r.replacement());
 }
 
 TEST_F(LoadEliminationTest, StoreFieldAndStoreElementAndLoadField) {
   Node* object = Parameter(Type::Any(), 0);
   Node* value = Parameter(Type::Any(), 1);
   Node* index = Parameter(Type::UnsignedSmall(), 2);
   Node* effect = graph()->start();
   Node* control = graph()->start();
-  FieldAccess access = {kTaggedBase,
-                        kPointerSize,
-                        MaybeHandle<Name>(),
-                        Type::Any(),
-                        MachineType::AnyTagged(),
+  FieldAccess access = {kTaggedBase,         kPointerSize,
+                        MaybeHandle<Name>(), MaybeHandle<Map>(),
+                        Type::Any(),         MachineType::AnyTagged(),
                         kNoWriteBarrier};
 
   StrictMock<MockAdvancedReducerEditor> editor;
   LoadElimination load_elimination(&editor, jsgraph(), zone());
 
   load_elimination.Reduce(graph()->start());
 
   Node* store1 = effect = graph()->NewNode(simplified()->StoreField(access),
                                            object, value, effect, control);
   load_elimination.Reduce(store1);
@@ skipping 79 matching lines @@
   Reduction r = load_elimination.Reduce(load);
   ASSERT_TRUE(r.Changed());
   EXPECT_EQ(load, r.replacement());
 }
 
 TEST_F(LoadEliminationTest, LoadFieldOnFalseBranchOfDiamond) {
   Node* object = Parameter(Type::Any(), 0);
   Node* check = Parameter(Type::Boolean(), 1);
   Node* effect = graph()->start();
   Node* control = graph()->start();
-  FieldAccess const access = {kTaggedBase,
-                              kPointerSize,
-                              MaybeHandle<Name>(),
-                              Type::Any(),
-                              MachineType::AnyTagged(),
+  FieldAccess const access = {kTaggedBase,         kPointerSize,
+                              MaybeHandle<Name>(), MaybeHandle<Map>(),
+                              Type::Any(),         MachineType::AnyTagged(),
                               kNoWriteBarrier};
 
   StrictMock<MockAdvancedReducerEditor> editor;
   LoadElimination load_elimination(&editor, jsgraph(), zone());
 
   load_elimination.Reduce(graph()->start());
 
   Node* branch = graph()->NewNode(common()->Branch(), check, control);
 
   Node* if_true = graph()->NewNode(common()->IfTrue(), branch);
@@ skipping 13 matching lines @@
   Reduction r = load_elimination.Reduce(load);
   ASSERT_TRUE(r.Changed());
   EXPECT_EQ(load, r.replacement());
 }
 
 TEST_F(LoadEliminationTest, LoadFieldOnTrueBranchOfDiamond) {
   Node* object = Parameter(Type::Any(), 0);
   Node* check = Parameter(Type::Boolean(), 1);
   Node* effect = graph()->start();
   Node* control = graph()->start();
-  FieldAccess const access = {kTaggedBase,
-                              kPointerSize,
-                              MaybeHandle<Name>(),
-                              Type::Any(),
-                              MachineType::AnyTagged(),
+  FieldAccess const access = {kTaggedBase,         kPointerSize,
+                              MaybeHandle<Name>(), MaybeHandle<Map>(),
+                              Type::Any(),         MachineType::AnyTagged(),
                               kNoWriteBarrier};
 
   StrictMock<MockAdvancedReducerEditor> editor;
   LoadElimination load_elimination(&editor, jsgraph(), zone());
 
   load_elimination.Reduce(graph()->start());
 
   Node* branch = graph()->NewNode(common()->Branch(), check, control);
 
   Node* if_true = graph()->NewNode(common()->IfTrue(), branch);
@@ skipping 13 matching lines @@
   Reduction r = load_elimination.Reduce(load);
   ASSERT_TRUE(r.Changed());
   EXPECT_EQ(load, r.replacement());
 }
 
 TEST_F(LoadEliminationTest, LoadFieldWithTypeMismatch) {
   Node* object = Parameter(Type::Any(), 0);
   Node* value = Parameter(Type::Signed32(), 1);
   Node* effect = graph()->start();
   Node* control = graph()->start();
-  FieldAccess const access = {kTaggedBase,
-                              kPointerSize,
-                              MaybeHandle<Name>(),
-                              Type::Unsigned31(),
-                              MachineType::AnyTagged(),
+  FieldAccess const access = {kTaggedBase,         kPointerSize,
+                              MaybeHandle<Name>(), MaybeHandle<Map>(),
+                              Type::Unsigned31(),  MachineType::AnyTagged(),
                               kNoWriteBarrier};
 
   StrictMock<MockAdvancedReducerEditor> editor;
   LoadElimination load_elimination(&editor, jsgraph(), zone());
 
   load_elimination.Reduce(graph()->start());
 
   Node* store = effect = graph()->NewNode(simplified()->StoreField(access),
                                           object, value, effect, control);
   load_elimination.Reduce(effect);
@@ skipping 33 matching lines @@
   Reduction r = load_elimination.Reduce(load);
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsTypeGuard(value, control));
 }
 
 TEST_F(LoadEliminationTest, AliasAnalysisForFinishRegion) {
   Node* value0 = Parameter(Type::Signed32(), 0);
   Node* value1 = Parameter(Type::Signed32(), 1);
   Node* effect = graph()->start();
   Node* control = graph()->start();
-  FieldAccess const access = {kTaggedBase,
-                              kPointerSize,
-                              MaybeHandle<Name>(),
-                              Type::Signed32(),
-                              MachineType::AnyTagged(),
+  FieldAccess const access = {kTaggedBase,         kPointerSize,
+                              MaybeHandle<Name>(), MaybeHandle<Map>(),
+                              Type::Signed32(),    MachineType::AnyTagged(),
                               kNoWriteBarrier};
 
   StrictMock<MockAdvancedReducerEditor> editor;
   LoadElimination load_elimination(&editor, jsgraph(), zone());
 
   load_elimination.Reduce(effect);
 
   effect = graph()->NewNode(
       common()->BeginRegion(RegionObservability::kNotObservable), effect);
   load_elimination.Reduce(effect);
@@ skipping 32 matching lines @@
                                 effect, control);
   EXPECT_CALL(editor, ReplaceWithValue(load, value0, effect, _));
   Reduction r = load_elimination.Reduce(load);
   ASSERT_TRUE(r.Changed());
   EXPECT_EQ(value0, r.replacement());
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8