Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Issue 2604173002: Prevent racey favicon loads in subresource filter browsertests. (Closed)

Created:
3 years, 11 months ago by engedy
Modified:
3 years, 11 months ago
Reviewers:
melandory
CC:
chromium-reviews, pkalinnikov
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent racey favicon loads in subresource filter browsertests. The favicon load was at race with the page load event, which caused flakiness in tests that verified, at page load completion time, the number of evaluated loads recorded into histograms. BUG=677370 Committed: https://crrev.com/311f7c0a14700bd54a1ee50c3f530334579ea99d Cr-Commit-Position: refs/heads/master@{#440956}

Patch Set 1 #

Patch Set 2 : Wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M chrome/browser/subresource_filter/subresource_filter_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/subresource_filter/frame_set.html View 1 1 chunk +18 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
engedy
Fixing some flakiness. Tanja, could you please take a look?
3 years, 11 months ago (2016-12-29 13:43:31 UTC) #4
melandory
On 2016/12/29 13:43:31, engedy wrote: > Fixing some flakiness. Tanja, could you please take a ...
3 years, 11 months ago (2016-12-29 13:47:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604173002/20001
3 years, 11 months ago (2016-12-29 13:48:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2016-12-29 14:46:46 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:18 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/311f7c0a14700bd54a1ee50c3f530334579ea99d
Cr-Commit-Position: refs/heads/master@{#440956}

Powered by Google App Engine
This is Rietveld 408576698