chrome/test/data/subresource_filter/frame_set.html - Issue 2604173002: Prevent racey favicon loads in subresource filter browsertests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/subresource_filter/frame_set.html

Issue 2604173002: Prevent racey favicon loads in subresource filter browsertests. (Closed)

Patch Set: Wording Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/subresource_filter/frame_set.html

diff --git a/chrome/test/data/subresource_filter/frame_set.html b/chrome/test/data/subresource_filter/frame_set.html

index 803b11fbd746f62c75d0d92ab435ea6d4c3585c9..11aacb87ec2727d0e3087fbba461b020956fd905 100644

--- a/chrome/test/data/subresource_filter/frame_set.html

+++ b/chrome/test/data/subresource_filter/frame_set.html

@@ -1,15 +1,23 @@

<html>

<head>

- <script type="text/javascript">

- function insertFrameWithScriptAndNotify() {

- var frame = document.createElement("iframe");

- frame.name = "dynamic";

- frame.src = "frame_with_included_script.html";

- frame.onload = () => window.domAutomationController.send(true)

- frame.onerror = () => window.domAutomationController.send(false)

- document.body.appendChild(frame);

- }

- </script>

+ <!--

+ The favicon resource load is at race with the page load event. Specify a

+ data URI as the source of the icon, so that the load is not evaluated by

+ the subresource filter. This prevent flakiness in tests that verify, at

+ page load completion time, that the correct number of evaluated loads

+ have been recorded into histograms.

+ -->

+ <link rel="icon" href="data:image/png;base64,">

+ <script type="text/javascript">

+ function insertFrameWithScriptAndNotify() {

+ var frame = document.createElement("iframe");

+ frame.name = "dynamic";

+ frame.src = "frame_with_included_script.html";

+ frame.onload = () => window.domAutomationController.send(true)

+ frame.onerror = () => window.domAutomationController.send(false)

+ document.body.appendChild(frame);

+ }

+ </script>

</head>

<body>

« no previous file with comments | « chrome/browser/subresource_filter/subresource_filter_browsertest.cc ('k') | no next file » | no next file with comments »