Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2604013003: [DevTools] Support variable height in ListControl. (Closed)

Created:
3 years, 11 months ago by dgozman
Modified:
3 years, 11 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Support variable height in ListControl. BUG=none Committed: https://crrev.com/0ea5c909d942f9ad43193e26d0653fcf47649811 Cr-Commit-Position: refs/heads/master@{#440939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+511 lines, -24 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height.js View 1 chunk +116 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height-expected.txt View 1 chunk +325 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 2 chunks +15 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/platform/utilities.js View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ListControl.js View 9 chunks +51 lines, -22 lines 0 comments Download

Depends on Patchset:

Issue 2592433003 Patch 200001

Dependent Patchsets:

Issue 2605253002 Patch 1

Messages

Total messages: 10 (5 generated)
dgozman
Could you please take a look?
3 years, 11 months ago (2016-12-28 22:48:22 UTC) #2
caseq
lgtm
3 years, 11 months ago (2016-12-28 23:17:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604013003/1
3 years, 11 months ago (2016-12-29 04:16:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 05:42:57 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:51:48 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0ea5c909d942f9ad43193e26d0653fcf47649811
Cr-Commit-Position: refs/heads/master@{#440939}

Powered by Google App Engine
This is Rietveld 408576698