Remove an isGlobalInitialized() check from WindowProxy::updateDocument()

Remove an isGlobalInitialized() check from WindowProxy::updateDocument()

Context states transit from Uninitialized to Initialized, and then to Detached.

- isGlobalInitialized() returns true when the context state is Initialized or Detached.
- isContextInitialized() returns true when the context state is Initialized.

Thus !isContextInitialized() is stronger than !isGlobalInitialized().
Hence we can remove if(!isGlobalInitialized()) from WindowProxy::updateDocument().

BUG=677253
Committed: https://crrev.com/403eecaa2fc7ea026528eecbdeeda3483b45ca6f
Cr-Commit-Position: refs/heads/master@{#440842}

[haraken, 2016-12-28 08:45:42]

haraken@chromium.org changed reviewers:
+ yukishiino@chromium.org

[haraken, 2016-12-28 08:45:43]

PTAL

https://codereview.chromium.org/2603953002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp (right):

https://codereview.chromium.org/2603953002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:471: if
(!isContextInitialized())

Actually I think this check is wrong. updateDocument should run when the context
is detached.

I'll address the issue in a follow up.

[haraken, 2016-12-28 08:52:37]

Description was changed from

==========
Remove an isGlobalInitialized() check from WindowProxy::updateDocument()

Context states transit from Uninitialized to Initialized, and then to Detached.

- isGlobalInitialized() returns true when the context state is Initialized or
Detached.
- isContextInitialized() returns true when the context state is Initialized.

Thus !isContextInitialized() is stronger than !isGlobalInitialized().
Hence we can remove if(!isGlobalInitialized()) from
WindowProxy::updateDocument().

BUG=
==========

to

==========
Remove an isGlobalInitialized() check from WindowProxy::updateDocument()

Context states transit from Uninitialized to Initialized, and then to Detached.

- isGlobalInitialized() returns true when the context state is Initialized or
Detached.
- isContextInitialized() returns true when the context state is Initialized.

Thus !isContextInitialized() is stronger than !isGlobalInitialized().
Hence we can remove if(!isGlobalInitialized()) from
WindowProxy::updateDocument().

BUG=677253
==========

[Yuki, 2016-12-28 08:53:19]

LGTM.

https://codereview.chromium.org/2603953002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp (right):

https://codereview.chromium.org/2603953002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:471: if
(!isContextInitialized())
On 2016/12/28 08:45:43, haraken wrote:
> 
> Actually I think this check is wrong. updateDocument should run when the
context
> is detached.
> 
> I'll address the issue in a follow up.

Why updateDocument should run when the context is detached?
If the frame is detached, then any navigation shouldn't happen.

[haraken, 2016-12-28 09:01:14]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-28 09:01:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-12-28 09:01:45]

On 2016/12/28 08:53:19, Yuki wrote:
> LGTM.
> 
>
https://codereview.chromium.org/2603953002/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp (right):
> 
>
https://codereview.chromium.org/2603953002/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:471: if
> (!isContextInitialized())
> On 2016/12/28 08:45:43, haraken wrote:
> > 
> > Actually I think this check is wrong. updateDocument should run when the
> context
> > is detached.
> > 
> > I'll address the issue in a follow up.
> 
> Why updateDocument should run when the context is detached?
> If the frame is detached, then any navigation shouldn't happen.

Yeah, it looks like we should insert a CHECK to verify that updateDocument is
not called after the context is detached.

[commit-bot: I haz the power, 2016-12-28 10:50:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482915674139750, "parent_rev":
"10954ef6bc12e05d3d45f3e4a0dc192b04f706ab", "commit_rev":
"ff77b59090336b679141be5d26f676164239ae7c"}

[commit-bot: I haz the power, 2016-12-28 10:50:58]

Description was changed from

==========
Remove an isGlobalInitialized() check from WindowProxy::updateDocument()

Context states transit from Uninitialized to Initialized, and then to Detached.

- isGlobalInitialized() returns true when the context state is Initialized or
Detached.
- isContextInitialized() returns true when the context state is Initialized.

Thus !isContextInitialized() is stronger than !isGlobalInitialized().
Hence we can remove if(!isGlobalInitialized()) from
WindowProxy::updateDocument().

BUG=677253
==========

to

==========
Remove an isGlobalInitialized() check from WindowProxy::updateDocument()

Context states transit from Uninitialized to Initialized, and then to Detached.

- isGlobalInitialized() returns true when the context state is Initialized or
Detached.
- isContextInitialized() returns true when the context state is Initialized.

Thus !isContextInitialized() is stronger than !isGlobalInitialized().
Hence we can remove if(!isGlobalInitialized()) from
WindowProxy::updateDocument().

BUG=677253

Review-Url: https://codereview.chromium.org/2603953002
==========

[commit-bot: I haz the power, 2016-12-28 10:50:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-02 15:48:49]

Description was changed from

==========
Remove an isGlobalInitialized() check from WindowProxy::updateDocument()

Context states transit from Uninitialized to Initialized, and then to Detached.

- isGlobalInitialized() returns true when the context state is Initialized or
Detached.
- isContextInitialized() returns true when the context state is Initialized.

Thus !isContextInitialized() is stronger than !isGlobalInitialized().
Hence we can remove if(!isGlobalInitialized()) from
WindowProxy::updateDocument().

BUG=677253

Review-Url: https://codereview.chromium.org/2603953002
==========

to

==========
Remove an isGlobalInitialized() check from WindowProxy::updateDocument()

Context states transit from Uninitialized to Initialized, and then to Detached.

- isGlobalInitialized() returns true when the context state is Initialized or
Detached.
- isContextInitialized() returns true when the context state is Initialized.

Thus !isContextInitialized() is stronger than !isGlobalInitialized().
Hence we can remove if(!isGlobalInitialized()) from
WindowProxy::updateDocument().

BUG=677253

Committed: https://crrev.com/403eecaa2fc7ea026528eecbdeeda3483b45ca6f
Cr-Commit-Position: refs/heads/master@{#440842}
==========

[commit-bot: I haz the power, 2017-01-02 15:48:49]

Patchset 1 (id:??) landed as
https://crrev.com/403eecaa2fc7ea026528eecbdeeda3483b45ca6f
Cr-Commit-Position: refs/heads/master@{#440842}