Remove an isGlobalInitialized() check from WindowProxy::updateDocument()

third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

 /*
  * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 450 matching lines @@
     token = frameSecurityToken + token;
   }
 
   // NOTE: V8 does identity comparison in fast path, must use a symbol
   // as the security token.
   context->SetSecurityToken(v8AtomicString(m_isolate, token));
 }
 
 void WindowProxy::updateDocument() {
   DCHECK(m_world->isMainWorld());
-  if (!isGlobalInitialized())
-    return;
   if (!isContextInitialized())

[haraken, 2016/12/28 08:45:43]

Actually I think this check is wrong. updateDocument should run when the context
is detached.

I'll address the issue in a follow up.

[Yuki, 2016/12/28 08:53:19]

Why updateDocument should run when the context is detached?
If the frame is detached, then any navigation shouldn't happen.

     return;
+
   updateActivityLogger();
   updateDocumentProperty();
   updateSecurityOrigin(m_frame->securityContext()->getSecurityOrigin());
 }
 
 static v8::Local<v8::Value> getNamedProperty(
     HTMLDocument* htmlDocument,
     const AtomicString& key,
     v8::Local<v8::Object> creationContext,
     v8::Isolate* isolate) {
@@ skipping 74 matching lines @@
       .ToChecked();
 }
 
 void WindowProxy::updateSecurityOrigin(SecurityOrigin* origin) {
   if (!isContextInitialized())
     return;
   setSecurityToken(origin);
 }
 
 }  // namespace blink