[SPInvalidation] Call layoutView->setNeedsPaintPropertyUpdate in FrameView::setNeedsPaintPropertyUp…

[SPInvalidation] Call layoutView->setNeedsPaintPropertyUpdate in FrameView::setNeedsPaintPropertyUpdate() when RLS is enabled

BUG=645667
TEST=Many test cases in webkit_unit_tests with RLS enabled with --enable-slimming-paint-invalidation

Committed: https://crrev.com/808b82b21b46ce5ee742e1eb813ba8890fe7f6ea
Cr-Commit-Position: refs/heads/master@{#440821}

[Xianzhu, 2016-12-26 20:19:58]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-26 20:20:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-26 21:44:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-26 21:44:30]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-12-27 17:41:36]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2016-12-27 18:05:46]

https://codereview.chromium.org/2603703002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2603703002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameView.cpp:1322: if
(RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
Why wouldn't the cases with RLS enabled be handled via regular overflow
scroll invalidation paths?

[Xianzhu, 2016-12-27 18:57:33]

https://codereview.chromium.org/2603703002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2603703002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameView.cpp:1322: if
(RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
On 2016/12/27 18:05:46, chrishtr wrote:
> Why wouldn't the cases with RLS enabled be handled via regular overflow
> scroll invalidation paths?

For scroll clip changes, the regular path is in LayoutBox::sizeChanged() which
doesn't apply to LayoutView whose overflow clip rect is derived from
FrameView::visibleContentRect() instead of LayoutBox::frameRect()
(https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...).

[Xianzhu, 2016-12-28 00:01:43]

On 2016/12/27 18:57:33, Xianzhu wrote:
>
https://codereview.chromium.org/2603703002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/frame/FrameView.cpp (right):
> 
>
https://codereview.chromium.org/2603703002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/frame/FrameView.cpp:1322: if
> (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
> On 2016/12/27 18:05:46, chrishtr wrote:
> > Why wouldn't the cases with RLS enabled be handled via regular overflow
> > scroll invalidation paths?
> 
> For scroll clip changes, the regular path is in LayoutBox::sizeChanged() which
> doesn't apply to LayoutView whose overflow clip rect is derived from
> FrameView::visibleContentRect() instead of LayoutBox::frameRect()
>
(https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...).

[chrishtr, 2016-12-28 00:32:17]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-28 00:32:18]

lgtm

[chrishtr, 2016-12-28 00:32:25]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-12-28 00:32:31]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-28 00:32:32]

lgtm

[commit-bot: I haz the power, 2016-12-28 00:32:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 02:20:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482885151904820, "parent_rev":
"973a93a234fda609397451d5964c9555b8f45757", "commit_rev":
"5fed5297359b6f33e528f712a9b5dcbca0743ca5"}

[commit-bot: I haz the power, 2016-12-28 02:21:22]

Description was changed from

==========
[SPInvalidation] Call layoutView->setNeedsPaintPropertyUpdate in
FrameView::setNeedsPaintPropertyUpdate() when RLS is enabled

BUG=645667
TEST=Many test cases in webkit_unit_tests with RLS enabled with
--enable-slimming-paint-invalidation
==========

to

==========
[SPInvalidation] Call layoutView->setNeedsPaintPropertyUpdate in
FrameView::setNeedsPaintPropertyUpdate() when RLS is enabled

BUG=645667
TEST=Many test cases in webkit_unit_tests with RLS enabled with
--enable-slimming-paint-invalidation

Review-Url: https://codereview.chromium.org/2603703002
==========

[commit-bot: I haz the power, 2016-12-28 02:21:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-02 15:48:15]

Description was changed from

==========
[SPInvalidation] Call layoutView->setNeedsPaintPropertyUpdate in
FrameView::setNeedsPaintPropertyUpdate() when RLS is enabled

BUG=645667
TEST=Many test cases in webkit_unit_tests with RLS enabled with
--enable-slimming-paint-invalidation

Review-Url: https://codereview.chromium.org/2603703002
==========

to

==========
[SPInvalidation] Call layoutView->setNeedsPaintPropertyUpdate in
FrameView::setNeedsPaintPropertyUpdate() when RLS is enabled

BUG=645667
TEST=Many test cases in webkit_unit_tests with RLS enabled with
--enable-slimming-paint-invalidation

Committed: https://crrev.com/808b82b21b46ce5ee742e1eb813ba8890fe7f6ea
Cr-Commit-Position: refs/heads/master@{#440821}
==========

[commit-bot: I haz the power, 2017-01-02 15:48:16]

Patchset 1 (id:??) landed as
https://crrev.com/808b82b21b46ce5ee742e1eb813ba8890fe7f6ea
Cr-Commit-Position: refs/heads/master@{#440821}