Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2603703002: [SPInvalidation] Call layoutView->setNeedsPaintPropertyUpdate in FrameView::setNeedsPaintPropertyUp… (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1301 matching lines...) Expand 10 before | Expand all | Expand 10 after
1312 RELEASE_ASSERT(!layoutViewItem().isNull()); 1312 RELEASE_ASSERT(!layoutViewItem().isNull());
1313 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled()) 1313 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled())
1314 invalidatePaintOfScrollControlsIfNeeded(paintInvalidationState); 1314 invalidatePaintOfScrollControlsIfNeeded(paintInvalidationState);
1315 1315
1316 if (m_frame->selection().isCaretBoundsDirty()) 1316 if (m_frame->selection().isCaretBoundsDirty())
1317 m_frame->selection().invalidateCaretRect(); 1317 m_frame->selection().invalidateCaretRect();
1318 } 1318 }
1319 1319
1320 void FrameView::setNeedsPaintPropertyUpdate() { 1320 void FrameView::setNeedsPaintPropertyUpdate() {
1321 m_needsPaintPropertyUpdate = true; 1321 m_needsPaintPropertyUpdate = true;
1322 if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
chrishtr 2016/12/27 18:05:46 Why wouldn't the cases with RLS enabled be handled
Xianzhu 2016/12/27 18:57:32 For scroll clip changes, the regular path is in La
1323 if (auto* layoutView = this->layoutView()) {
1324 layoutView->setNeedsPaintPropertyUpdate();
1325 return;
1326 }
1327 }
1322 if (LayoutObject* owner = frame().ownerLayoutObject()) 1328 if (LayoutObject* owner = frame().ownerLayoutObject())
1323 owner->setNeedsPaintPropertyUpdate(); 1329 owner->setNeedsPaintPropertyUpdate();
1324 } 1330 }
1325 1331
1326 void FrameView::setSubtreeNeedsPaintPropertyUpdate() { 1332 void FrameView::setSubtreeNeedsPaintPropertyUpdate() {
1327 setNeedsPaintPropertyUpdate(); 1333 setNeedsPaintPropertyUpdate();
1328 layoutView()->setSubtreeNeedsPaintPropertyUpdate(); 1334 layoutView()->setSubtreeNeedsPaintPropertyUpdate();
1329 } 1335 }
1330 1336
1331 IntRect FrameView::computeVisibleArea() { 1337 IntRect FrameView::computeVisibleArea() {
(...skipping 3561 matching lines...) Expand 10 before | Expand all | Expand 10 after
4893 reason < MainThreadScrollingReason::kMainThreadScrollingReasonCount; 4899 reason < MainThreadScrollingReason::kMainThreadScrollingReasonCount;
4894 ++reason) { 4900 ++reason) {
4895 if (m_mainThreadScrollingReasonsCounter[reason] > 0) { 4901 if (m_mainThreadScrollingReasonsCounter[reason] > 0) {
4896 reasons |= 1 << (reason - 1); 4902 reasons |= 1 << (reason - 1);
4897 } 4903 }
4898 } 4904 }
4899 return reasons; 4905 return reasons;
4900 } 4906 }
4901 4907
4902 } // namespace blink 4908 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698