Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2603453002: MD Settings: Fix policy-related reentrancy crash for People page. (Closed)

Created:
3 years, 12 months ago by tommycli
Modified:
3 years, 12 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix policy-related reentrancy crash for People page. Repro steps: 1) Using MD Settings, sign in with SyncDisabled policy set to true. 2) Set SyncDisabled policy to false. 3) Click the Sync Settings row. 4) Observe DCHECK crash. BUG=651303 Committed: https://crrev.com/99de28a9d7fa3add65428268fbda05935e7421fe Cr-Commit-Position: refs/heads/master@{#440529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/ui/webui/settings/people_handler.cc View 3 chunks +4 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
tommycli
dbeam: PTAL, thanks!
3 years, 12 months ago (2016-12-22 21:13:43 UTC) #6
Dan Beam
lgtm howwww much work would a test be?
3 years, 12 months ago (2016-12-22 22:06:12 UTC) #7
tommycli
On 2016/12/22 22:06:12, Dan Beam wrote: > lgtm > > howwww much work would a ...
3 years, 12 months ago (2016-12-22 22:30:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603453002/1
3 years, 12 months ago (2016-12-22 22:32:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-22 22:39:34 UTC) #13
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 22:43:59 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99de28a9d7fa3add65428268fbda05935e7421fe
Cr-Commit-Position: refs/heads/master@{#440529}

Powered by Google App Engine
This is Rietveld 408576698