MD Settings: Fix policy-related ProfileSyncService crashes.

MD Settings: Fix policy-related ProfileSyncService crashes.

General repro steps:
 1) Sign in with MD Settings.
 2) Set SyncDisabled to true and wait for it to take effect.
 3) MD Settings will crash shortly.

BUG=651303
Committed: https://crrev.com/7c176719b12185d6ddbf531d825884dfb457e755
Cr-Commit-Position: refs/heads/master@{#440531}

[tommycli, 2016-12-22 20:37:11]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 20:37:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-12-22 21:14:05]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2016-12-22 21:14:06]

dbeam: PTAL, thanks!

[commit-bot: I haz the power, 2016-12-22 21:15:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 21:15:11]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-12-22 22:07:40]

lgtm but maybe a test?

https://codereview.chromium.org/2598073002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/people_handler.cc (right):

https://codereview.chromium.org/2598073002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/people_handler.cc:910: if (!service ||
service->IsFirstSetupComplete())
nit: is there somehow we can check that if !service that we're disabled by
policy?

[tommycli, 2016-12-22 22:46:16]

also probably not worth the test. all the instances of DCHECK(service) were just
wrong, since GetSyncService() can explicitly return nullptr.

https://codereview.chromium.org/2598073002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/people_handler.cc (right):

https://codereview.chromium.org/2598073002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/people_handler.cc:910: if (!service ||
service->IsFirstSetupComplete())
On 2016/12/22 22:07:40, Dan Beam wrote:
> nit: is there somehow we can check that if !service that we're disabled by
> policy?

Well... it's more like, GetSyncService() returns nullptr if
profile->IsSyncAllowed() is false:
https://codesearch.chromium.org/chromium/src/chrome/browser/ui/webui/settings...

So adding a DCHECK would be pretty tautological.

[tommycli, 2016-12-22 22:46:20]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-12-22 22:46:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 22:50:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482446780093000, "parent_rev":
"f8fb75c86a896f6826d353ef7f38cfc495ba0463", "commit_rev":
"d12a94ea3d00b60556fa4e10dcdb4dade276f195"}

[commit-bot: I haz the power, 2016-12-22 22:51:17]

Description was changed from

==========
MD Settings: Fix policy-related ProfileSyncService crashes.

General repro steps:
 1) Sign in with MD Settings.
 2) Set SyncDisabled to true and wait for it to take effect.
 3) MD Settings will crash shortly.

BUG=651303
==========

to

==========
MD Settings: Fix policy-related ProfileSyncService crashes.

General repro steps:
 1) Sign in with MD Settings.
 2) Set SyncDisabled to true and wait for it to take effect.
 3) MD Settings will crash shortly.

BUG=651303

Review-Url: https://codereview.chromium.org/2598073002
==========

[commit-bot: I haz the power, 2016-12-22 22:51:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-22 22:53:34]

Description was changed from

==========
MD Settings: Fix policy-related ProfileSyncService crashes.

General repro steps:
 1) Sign in with MD Settings.
 2) Set SyncDisabled to true and wait for it to take effect.
 3) MD Settings will crash shortly.

BUG=651303

Review-Url: https://codereview.chromium.org/2598073002
==========

to

==========
MD Settings: Fix policy-related ProfileSyncService crashes.

General repro steps:
 1) Sign in with MD Settings.
 2) Set SyncDisabled to true and wait for it to take effect.
 3) MD Settings will crash shortly.

BUG=651303

Committed: https://crrev.com/7c176719b12185d6ddbf531d825884dfb457e755
Cr-Commit-Position: refs/heads/master@{#440531}
==========

[commit-bot: I haz the power, 2016-12-22 22:53:35]

Patchset 1 (id:??) landed as
https://crrev.com/7c176719b12185d6ddbf531d825884dfb457e755
Cr-Commit-Position: refs/heads/master@{#440531}