Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2603363002: [ios] Deletes tab_util.h and tab_util.mm. (Closed)

Created:
3 years, 11 months ago by rohitrao (ping after 24h)
Modified:
3 years, 11 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Deletes tab_util.h and tab_util.mm. This file contains tab drawing routines that are no longer used. BUG=677941 Committed: https://crrev.com/a3666d04c66f90be65160936b5a1a16e0db54f6e Cr-Commit-Position: refs/heads/master@{#441163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -96 lines) Patch
M ios/chrome/browser/ui/stack_view/card_view.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/tabs/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ios/chrome/browser/ui/tabs/tab_util.h View 1 chunk +0 lines, -20 lines 0 comments Download
D ios/chrome/browser/ui/tabs/tab_util.mm View 1 chunk +0 lines, -72 lines 0 comments Download
M ios/chrome/browser/ui/tabs/tab_view.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
rohitrao (ping after 24h)
3 years, 11 months ago (2017-01-03 15:51:28 UTC) #4
sdefresne
lgtm
3 years, 11 months ago (2017-01-03 16:05:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603363002/1
3 years, 11 months ago (2017-01-03 18:21:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 18:25:53 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 18:30:51 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3666d04c66f90be65160936b5a1a16e0db54f6e
Cr-Commit-Position: refs/heads/master@{#441163}

Powered by Google App Engine
This is Rietveld 408576698