Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2603283003: [MD Settings][People] Force sign out only in the case of unrecoverable error (Closed)

Created:
3 years, 11 months ago by Moe
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[MD Settings][People] Force sign out only in the case of unrecoverable error BUG=674000 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2591093002 Cr-Commit-Position: refs/heads/master@{#440410} (cherry picked from commit 2280c8fda1618773a1d572a8abd2663b754cd486) Committed: https://chromium.googlesource.com/chromium/src/+/9d661228218c77361177eeffb20466fd1ccbc74d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -43 lines) Patch
M chrome/browser/resources/options/browser_options.js View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.js View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/sync_browser_proxy.js View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.cc View 5 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler_unittest.cc View 15 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Moe
3 years, 11 months ago (2017-01-03 20:06:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9d661228218c77361177eeffb20466fd1ccbc74d.

Powered by Google App Engine
This is Rietveld 408576698