Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3472)

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler.cc

Issue 2603283003: [MD Settings][People] Force sign out only in the case of unrecoverable error (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/sync_setup_handler.cc
diff --git a/chrome/browser/ui/webui/options/sync_setup_handler.cc b/chrome/browser/ui/webui/options/sync_setup_handler.cc
index dd7f02746a759a14ff439d56a350304fb2ea059a..5d890d1223c93fd77e7ea5f182663e80e95571da 100644
--- a/chrome/browser/ui/webui/options/sync_setup_handler.cc
+++ b/chrome/browser/ui/webui/options/sync_setup_handler.cc
@@ -647,8 +647,11 @@ void SyncSetupHandler::HandleAttemptUserExit(const base::ListValue* args) {
#if !defined(OS_CHROMEOS)
void SyncSetupHandler::HandleStartSignin(const base::ListValue* args) {
- // Should only be called if the user is not already signed in.
- DCHECK(!SigninManagerFactory::GetForProfile(GetProfile())->IsAuthenticated());
+ // Should only be called if the user is not already signed in or has an auth
+ // error.
+ DCHECK(
+ !SigninManagerFactory::GetForProfile(GetProfile())->IsAuthenticated() ||
+ SigninErrorControllerFactory::GetForProfile(GetProfile())->HasError());
bool creating_supervised_user = false;
args->GetBoolean(0, &creating_supervised_user);
OpenSyncSetup(creating_supervised_user);
« no previous file with comments | « chrome/browser/ui/webui/options/browser_options_handler.cc ('k') | chrome/browser/ui/webui/settings/people_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698