Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2591093002: [MD Settings][People] Force sign out only in the case of unrecoverable error (Closed)

Created:
4 years ago by Moe
Modified:
4 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Settings][People] Force sign out only in the case of unrecoverable error BUG=674000 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2280c8fda1618773a1d572a8abd2663b754cd486 Cr-Commit-Position: refs/heads/master@{#440410}

Patch Set 1 #

Patch Set 2 : Fixed compilation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -43 lines) Patch
M chrome/browser/resources/options/browser_options.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.js View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/sync_browser_proxy.js View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.cc View 5 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler_unittest.cc View 1 15 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Moe
Hi Tommy, Could you please take a look at this CL? It fixes a bug ...
4 years ago (2016-12-20 21:19:07 UTC) #5
tommycli
lgtm very clean patch
4 years ago (2016-12-21 19:29:56 UTC) #12
Moe
Hi Please take a look at this CL. (for merge into M56) dbeam@ owners review ...
4 years ago (2016-12-21 20:00:07 UTC) #14
Nicolas Zea
lgtm
4 years ago (2016-12-21 21:30:57 UTC) #15
Dan Beam
/options/ lgtm
4 years ago (2016-12-22 03:25:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591093002/20001
4 years ago (2016-12-22 13:22:36 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-22 14:16:47 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-22 14:20:20 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2280c8fda1618773a1d572a8abd2663b754cd486
Cr-Commit-Position: refs/heads/master@{#440410}

Powered by Google App Engine
This is Rietveld 408576698