Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2603263002: Prefix resolution_types with Resolution. (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2841 lines, -2462 lines) Patch
M pkg/compiler/lib/src/closure.dart View 12 chunks +25 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 1 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 6 chunks +17 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 21 chunks +32 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 6 chunks +32 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/constant_system_dart.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_constructors.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_system.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/constants/constructors.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 24 chunks +33 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 1 18 chunks +25 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/core_types.dart View 1 1 chunk +18 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 2 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 1 4 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 13 chunks +30 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 48 chunks +79 lines, -72 lines 0 comments Download
M pkg/compiler/lib/src/elements/resolution_types.dart View 1 86 chunks +382 lines, -313 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 6 chunks +9 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 2 chunks +8 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 20 chunks +27 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 1 7 chunks +15 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 5 chunks +13 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 44 chunks +116 lines, -109 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/constant_ordering.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 1 4 chunks +12 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 6 chunks +8 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 7 chunks +9 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 1 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/kernel/error.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 1 11 chunks +26 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 16 chunks +23 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/kernel/unresolved.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 1 3 chunks +8 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 14 chunks +28 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 6 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/native/ssa.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 11 chunks +62 lines, -48 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 4 chunks +7 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 21 chunks +42 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 14 chunks +39 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 8 chunks +13 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 3 chunks +9 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/resolution/member_impl.dart View 1 13 chunks +29 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 33 chunks +55 lines, -43 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 5 chunks +11 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 7 chunks +22 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_result.dart View 1 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/scope.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 17 chunks +25 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 1 35 chunks +70 lines, -49 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 10 chunks +26 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 6 chunks +11 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 10 chunks +37 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/serialization/constant_serialization.dart View 1 4 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 5 chunks +10 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 7 chunks +21 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/serialization/impact_serialization.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 33 chunks +80 lines, -72 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization.dart View 1 15 chunks +27 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization_util.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/type_serialization.dart View 1 2 chunks +35 lines, -30 lines 0 comments Download
M pkg/compiler/lib/src/serialization/values.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 38 chunks +81 lines, -67 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 11 chunks +18 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 13 chunks +20 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 1 6 chunks +20 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 14 chunks +38 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 4 chunks +9 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 10 chunks +17 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/ssa/type_builder.dart View 9 chunks +16 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 71 chunks +245 lines, -222 lines 0 comments Download
M pkg/compiler/lib/src/types/abstract_value_domain.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/feature.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 1 5 chunks +18 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 17 chunks +22 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_dart2js_helpers_test.dart View 5 chunks +7 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/flatten_test.dart View 2 chunks +10 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 3 chunks +14 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/least_upper_bound_test.dart View 6 chunks +87 lines, -78 lines 0 comments Download
M tests/compiler/dart2js/lookup_member_test.dart View 1 chunk +14 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/members_test.dart View 14 chunks +61 lines, -61 lines 0 comments Download
M tests/compiler/dart2js/mixin_typevariable_test.dart View 9 chunks +13 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/related_types.dart View 7 chunks +106 lines, -87 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 4 chunks +6 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_decl_visitor.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart View 12 chunks +20 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 3 chunks +7 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/subtype_test.dart View 9 chunks +66 lines, -60 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_equals_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_order_test.dart View 1 chunk +26 lines, -25 lines 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 3 chunks +19 lines, -19 lines 0 comments Download
M tests/compiler/dart2js/type_substitution_test.dart View 5 chunks +36 lines, -29 lines 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 2 chunks +21 lines, -18 lines 0 comments Download
M tests/compiler/dart2js/type_variable_occurrence_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-02 15:05:32 UTC) #2
Johnni Winther
ping
3 years, 11 months ago (2017-01-03 10:03:17 UTC) #3
Siggi Cherem (dart-lang)
while the rename seems totally OK, let's wait until we sync up in person before ...
3 years, 11 months ago (2017-01-03 23:01:26 UTC) #4
Siggi Cherem (dart-lang)
lgtm
3 years, 11 months ago (2017-01-04 23:29:39 UTC) #5
Johnni Winther
3 years, 11 months ago (2017-01-05 12:10:30 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
51e3c01e3e06ad42e511aca4c3158078279bfa27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698