Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: pkg/compiler/lib/src/ssa/kernel_impact.dart

Issue 2603263002: Prefix resolution_types with Resolution. (Closed)
Patch Set: Rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart ('k') | pkg/compiler/lib/src/ssa/locals_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/kernel_impact.dart
diff --git a/pkg/compiler/lib/src/ssa/kernel_impact.dart b/pkg/compiler/lib/src/ssa/kernel_impact.dart
index 7c631222632e01fe5ce8abfe892f534b4002ce9a..740d723cdeddcf5f83aafdbc3d294ce6bd26ef2b 100644
--- a/pkg/compiler/lib/src/ssa/kernel_impact.dart
+++ b/pkg/compiler/lib/src/ssa/kernel_impact.dart
@@ -78,8 +78,8 @@ class KernelImpactBuilder extends ir.Visitor {
}
/// Add a checked-mode type use of [type] if it is not `dynamic`.
- DartType checkType(ir.DartType irType) {
- DartType type = astAdapter.getDartType(irType);
+ ResolutionDartType checkType(ir.DartType irType) {
+ ResolutionDartType type = astAdapter.getDartType(irType);
if (!type.isDynamic) {
impactBuilder.registerTypeUse(new TypeUse.checkedModeCheck(type));
}
@@ -219,7 +219,7 @@ class KernelImpactBuilder extends ir.Visitor {
@override
void visitListLiteral(ir.ListLiteral literal) {
visitNodes(literal.expressions);
- DartType elementType = checkType(literal.typeArgument);
+ ResolutionDartType elementType = checkType(literal.typeArgument);
impactBuilder.registerListLiteral(new ListLiteralUse(
compiler.commonElements.listType(elementType),
@@ -230,8 +230,8 @@ class KernelImpactBuilder extends ir.Visitor {
@override
void visitMapLiteral(ir.MapLiteral literal) {
visitNodes(literal.entries);
- DartType keyType = checkType(literal.keyType);
- DartType valueType = checkType(literal.valueType);
+ ResolutionDartType keyType = checkType(literal.keyType);
+ ResolutionDartType valueType = checkType(literal.valueType);
impactBuilder.registerMapLiteral(new MapLiteralUse(
compiler.commonElements.mapType(keyType, valueType),
isConstant: literal.isConst,
@@ -258,14 +258,15 @@ class KernelImpactBuilder extends ir.Visitor {
_visitArguments(node.arguments);
Element element = astAdapter.getElement(target).declaration;
ClassElement cls = astAdapter.getElement(target.enclosingClass);
- List<DartType> typeArguments =
+ List<ResolutionDartType> typeArguments =
astAdapter.getDartTypes(node.arguments.types);
- InterfaceType type = new InterfaceType(cls, typeArguments);
+ ResolutionInterfaceType type =
+ new ResolutionInterfaceType(cls, typeArguments);
CallStructure callStructure = astAdapter.getCallStructure(node.arguments);
impactBuilder.registerStaticUse(isConst
? new StaticUse.constConstructorInvoke(element, callStructure, type)
: new StaticUse.typedConstructorInvoke(element, callStructure, type));
- if (typeArguments.any((DartType type) => !type.isDynamic)) {
+ if (typeArguments.any((ResolutionDartType type) => !type.isDynamic)) {
impactBuilder.registerFeature(Feature.TYPE_VARIABLE_BOUNDS_CHECK);
}
}
« no previous file with comments | « pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart ('k') | pkg/compiler/lib/src/ssa/locals_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698