Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1907)

Unified Diff: pkg/compiler/lib/src/kernel/kernel_visitor.dart

Issue 2603263002: Prefix resolution_types with Resolution. (Closed)
Patch Set: Rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel.dart ('k') | pkg/compiler/lib/src/kernel/unresolved.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/kernel/kernel_visitor.dart
diff --git a/pkg/compiler/lib/src/kernel/kernel_visitor.dart b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
index ceb58a79d74202fa06bfd28eef5c52f1c8a77641..905ea0f5477c365910614ec6b1903358e6698aca 100644
--- a/pkg/compiler/lib/src/kernel/kernel_visitor.dart
+++ b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
@@ -31,7 +31,8 @@ import '../constants/expressions.dart'
IntFromEnvironmentConstantExpression,
StringFromEnvironmentConstantExpression,
TypeConstantExpression;
-import '../elements/resolution_types.dart' show DartType, InterfaceType;
+import '../elements/resolution_types.dart'
+ show ResolutionDartType, ResolutionInterfaceType;
import '../diagnostics/spannable.dart' show Spannable;
import '../elements/elements.dart'
show
@@ -259,7 +260,7 @@ class KernelVisitor extends Object
// This works around a bug in dart2js.
// TODO(ahe): Fix the bug in dart2js and remove this function.
- ir.DartType typeToIrHack(DartType type) {
+ ir.DartType typeToIrHack(ResolutionDartType type) {
if (currentElement.isSynthesized &&
currentElement.enclosingClass.isMixinApplication &&
!kernel.hasHierarchyProblem(currentElement.enclosingClass)) {
@@ -283,7 +284,7 @@ class KernelVisitor extends Object
// is Super<S> and it should be Sub<T>, but we settle for Super<T> for
// now). So we need to translate Sub<T> to an instance of Super, which is
// Super<T> (not Super<S>).
- InterfaceType supertype =
+ ResolutionInterfaceType supertype =
currentElement.enclosingClass.asInstanceOf(superclass);
// Once we have [supertype], we know how to substitute S with T: the type
// arguments of [supertype] corresponds to T, and the type variables of
@@ -1121,7 +1122,7 @@ class KernelVisitor extends Object
ir.InvalidExpression visitAbstractClassConstructorInvoke(
NewExpression node,
ConstructorElement element,
- InterfaceType type,
+ ResolutionInterfaceType type,
NodeList arguments,
CallStructure callStructure,
_) {
@@ -1146,7 +1147,8 @@ class KernelVisitor extends Object
}
@override
- ir.AsExpression visitAs(Send node, Node expression, DartType type, _) {
+ ir.AsExpression visitAs(
+ Send node, Node expression, ResolutionDartType type, _) {
return new ir.AsExpression(
visitForValue(expression), kernel.typeToIr(type));
}
@@ -1172,7 +1174,7 @@ class KernelVisitor extends Object
isConst: isConst)
: buildStaticInvoke(target.element, arguments, isConst: isConst);
if (target.type.isInterfaceType) {
- InterfaceType type = target.type;
+ ResolutionInterfaceType type = target.type;
if (type.isGeneric) {
invoke.arguments.types.addAll(kernel.typesToIr(type.typeArguments));
}
@@ -1261,7 +1263,7 @@ class KernelVisitor extends Object
ir.InvalidExpression visitConstructorIncompatibleInvoke(
NewExpression node,
ConstructorElement constructor,
- InterfaceType type,
+ ResolutionInterfaceType type,
NodeList arguments,
CallStructure callStructure,
_) {
@@ -1370,7 +1372,7 @@ class KernelVisitor extends Object
ir.InvocationExpression visitFactoryConstructorInvoke(
NewExpression node,
ConstructorElement constructor,
- InterfaceType type,
+ ResolutionInterfaceType type,
NodeList arguments,
CallStructure callStructure,
_) {
@@ -1499,7 +1501,7 @@ class KernelVisitor extends Object
ir.InvocationExpression visitGenerativeConstructorInvoke(
NewExpression node,
ConstructorElement constructor,
- InterfaceType type,
+ ResolutionInterfaceType type,
NodeList arguments,
CallStructure callStructure,
_) {
@@ -1571,7 +1573,7 @@ class KernelVisitor extends Object
@override
ir.Initializer visitImplicitSuperConstructorInvoke(FunctionExpression node,
- ConstructorElement superConstructor, InterfaceType type, _) {
+ ConstructorElement superConstructor, ResolutionInterfaceType type, _) {
if (superConstructor == null) {
// TODO(ahe): Semantic visitor shouldn't call this.
return new ir.InvalidInitializer();
@@ -1667,18 +1669,19 @@ class KernelVisitor extends Object
return buildConstructorInvoke(node, isConst: true);
}
- ir.IsExpression buildIs(Node expression, DartType type) {
+ ir.IsExpression buildIs(Node expression, ResolutionDartType type) {
return new ir.IsExpression(
visitForValue(expression), kernel.typeToIr(type));
}
@override
- ir.IsExpression visitIs(Send node, Node expression, DartType type, _) {
+ ir.IsExpression visitIs(
+ Send node, Node expression, ResolutionDartType type, _) {
return buildIs(expression, type);
}
@override
- ir.Not visitIsNot(Send node, Node expression, DartType type, _) {
+ ir.Not visitIsNot(Send node, Node expression, ResolutionDartType type, _) {
return new ir.Not(buildIs(expression, type));
}
@@ -1899,7 +1902,7 @@ class KernelVisitor extends Object
FunctionExpression node,
ConstructorElement constructor,
NodeList parameters,
- DartType redirectionType, // TODO(ahe): Should be InterfaceType.
+ ResolutionDartType redirectionType, // TODO(ahe): Should be InterfaceType.
ConstructorElement redirectionTarget,
_) {
if (!constructor.isFactoryConstructor) {
@@ -1928,9 +1931,9 @@ class KernelVisitor extends Object
ir.InvocationExpression visitRedirectingFactoryConstructorInvoke(
NewExpression node,
ConstructorElement constructor,
- InterfaceType type,
+ ResolutionInterfaceType type,
ConstructorElement effectiveTarget,
- InterfaceType effectiveTargetType,
+ ResolutionInterfaceType effectiveTargetType,
NodeList arguments,
CallStructure callStructure,
_) {
@@ -1951,7 +1954,7 @@ class KernelVisitor extends Object
ir.InvocationExpression visitRedirectingGenerativeConstructorInvoke(
NewExpression node,
ConstructorElement constructor,
- InterfaceType type,
+ ResolutionInterfaceType type,
NodeList arguments,
CallStructure callStructure,
_) {
@@ -2060,10 +2063,10 @@ class KernelVisitor extends Object
returnType = typeToIrHack(signature.type.returnType);
}
if (function.isFactoryConstructor) {
- InterfaceType type = function.enclosingClass.thisType;
+ ResolutionInterfaceType type = function.enclosingClass.thisType;
if (type.isGeneric) {
typeParameters = new List<ir.TypeParameter>();
- for (DartType parameter in type.typeArguments) {
+ for (ResolutionDartType parameter in type.typeArguments) {
typeParameters.add(kernel.typeVariableToIr(parameter.element));
}
}
@@ -2297,7 +2300,7 @@ class KernelVisitor extends Object
ir.Initializer visitSuperConstructorInvoke(
Send node,
ConstructorElement superConstructor,
- InterfaceType type,
+ ResolutionInterfaceType type,
NodeList arguments,
CallStructure callStructure,
_) {
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel.dart ('k') | pkg/compiler/lib/src/kernel/unresolved.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698