Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2603063002: Only clear tooltip message on a user scroll or compositor scroll. (Closed)
Patch Set: Add test, handle non-RLS frame scroll case. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 7befa59cab9596c4259b88f2b9181b14a778f3c7..7bd6f7d99b8069848ed49ca77198f2a2947e59b0 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -3816,9 +3816,10 @@ void FrameView::updateScrollOffset(const ScrollOffset& offset,
document->enqueueScrollEventForNode(document);
m_frame->eventHandler().dispatchFakeMouseMoveEventSoon();
- Page* page = frame().page();
- if (page)
- page->chromeClient().clearToolTip(*m_frame);
+ if (scrollType == UserScroll || scrollType == CompositorScroll) {
+ if (Page* page = frame().page())
tdresser 2017/01/03 13:56:32 Moving the assignment to within the conditional ma
+ page->chromeClient().clearToolTip(*m_frame);
+ }
LayoutViewItem layoutViewItem = document->layoutViewItem();
if (!layoutViewItem.isNull()) {

Powered by Google App Engine
This is Rietveld 408576698