Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2603063002: Only clear tooltip message on a user scroll or compositor scroll. (Closed)
Patch Set: Add test, handle non-RLS frame scroll case. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
index 7a7d3894ed88097c3eff07c36ea5c819f6b11e88..a37cf224342f844afcb63a2dfb4d9c66539a0d8c 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
@@ -413,9 +413,10 @@ void PaintLayerScrollableArea::updateScrollOffset(const ScrollOffset& newOffset,
frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(
quadForFakeMouseMoveEvent);
- Page* page = frame->page();
- if (page)
- page->chromeClient().clearToolTip(*frame);
+ if (scrollType == UserScroll || scrollType == CompositorScroll) {
+ if (Page* page = frame->page())
tdresser 2017/01/03 13:56:32 Why move this assignment into the conditional?
szager1 2017/01/03 20:24:22 I have no opinion on this. I restored the previou
bokan 2017/01/04 23:53:09 No need to change anything again, just FYI, but I
+ page->chromeClient().clearToolTip(*frame);
+ }
bool requiresPaintInvalidation = true;

Powered by Google App Engine
This is Rietveld 408576698