Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2603063002: Only clear tooltip message on a user scroll or compositor scroll. (Closed)
Patch Set: Add test, handle non-RLS frame scroll case. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 3798 matching lines...) Expand 10 before | Expand all | Expand 10 after
3809 m_pendingScrollDelta += scrollDelta; 3809 m_pendingScrollDelta += scrollDelta;
3810 3810
3811 if (scrollTypeClearsFragmentAnchor(scrollType)) 3811 if (scrollTypeClearsFragmentAnchor(scrollType))
3812 clearFragmentAnchor(); 3812 clearFragmentAnchor();
3813 updateLayersAndCompositingAfterScrollIfNeeded(); 3813 updateLayersAndCompositingAfterScrollIfNeeded();
3814 3814
3815 Document* document = m_frame->document(); 3815 Document* document = m_frame->document();
3816 document->enqueueScrollEventForNode(document); 3816 document->enqueueScrollEventForNode(document);
3817 3817
3818 m_frame->eventHandler().dispatchFakeMouseMoveEventSoon(); 3818 m_frame->eventHandler().dispatchFakeMouseMoveEventSoon();
3819 Page* page = frame().page(); 3819 if (scrollType == UserScroll || scrollType == CompositorScroll) {
3820 if (page) 3820 if (Page* page = frame().page())
tdresser 2017/01/03 13:56:32 Moving the assignment to within the conditional ma
3821 page->chromeClient().clearToolTip(*m_frame); 3821 page->chromeClient().clearToolTip(*m_frame);
3822 }
3822 3823
3823 LayoutViewItem layoutViewItem = document->layoutViewItem(); 3824 LayoutViewItem layoutViewItem = document->layoutViewItem();
3824 if (!layoutViewItem.isNull()) { 3825 if (!layoutViewItem.isNull()) {
3825 if (layoutViewItem.usesCompositing()) 3826 if (layoutViewItem.usesCompositing())
3826 layoutViewItem.compositor()->frameViewDidScroll(); 3827 layoutViewItem.compositor()->frameViewDidScroll();
3827 layoutViewItem.clearHitTestCache(); 3828 layoutViewItem.clearHitTestCache();
3828 } 3829 }
3829 3830
3830 m_didScrollTimer.startOneShot(resourcePriorityUpdateDelayAfterScroll, 3831 m_didScrollTimer.startOneShot(resourcePriorityUpdateDelayAfterScroll,
3831 BLINK_FROM_HERE); 3832 BLINK_FROM_HERE);
(...skipping 1070 matching lines...) Expand 10 before | Expand all | Expand 10 after
4902 reason < MainThreadScrollingReason::kMainThreadScrollingReasonCount; 4903 reason < MainThreadScrollingReason::kMainThreadScrollingReasonCount;
4903 ++reason) { 4904 ++reason) {
4904 if (m_mainThreadScrollingReasonsCounter[reason] > 0) { 4905 if (m_mainThreadScrollingReasonsCounter[reason] > 0) {
4905 reasons |= 1 << (reason - 1); 4906 reasons |= 1 << (reason - 1);
4906 } 4907 }
4907 } 4908 }
4908 return reasons; 4909 return reasons;
4909 } 4910 }
4910 4911
4911 } // namespace blink 4912 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698