Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2603053002: [Devtools] Type externs global namespaces (Closed)

Created:
3 years, 11 months ago by allada
Modified:
3 years, 11 months ago
Reviewers:
chenwilliam, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Type externs global namespaces This patch adds type casting for our global namespace. R=dgozman,chenwilliam BUG=None Committed: https://crrev.com/6f7a44a7e02604548056a6fbf18b69bbc1ff583a Cr-Commit-Position: refs/heads/master@{#441012}

Patch Set 1 #

Total comments: 2

Patch Set 2 : [Devtools] Type externs global namespaces #

Patch Set 3 : Merge branch 'master' into TYPE_EXTERN_GLOBALS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 1 2 2 chunks +48 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
allada
PTL
3 years, 11 months ago (2016-12-29 22:48:09 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2603053002/diff/1/third_party/WebKit/Source/devtools/front_end/externs.js File third_party/WebKit/Source/devtools/front_end/externs.js (right): https://codereview.chromium.org/2603053002/diff/1/third_party/WebKit/Source/devtools/front_end/externs.js#newcode742 third_party/WebKit/Source/devtools/front_end/externs.js:742: /** @enum {function()} */ !Object
3 years, 11 months ago (2016-12-29 23:48:25 UTC) #2
allada
https://codereview.chromium.org/2603053002/diff/1/third_party/WebKit/Source/devtools/front_end/externs.js File third_party/WebKit/Source/devtools/front_end/externs.js (right): https://codereview.chromium.org/2603053002/diff/1/third_party/WebKit/Source/devtools/front_end/externs.js#newcode742 third_party/WebKit/Source/devtools/front_end/externs.js:742: /** @enum {function()} */ On 2016/12/29 23:48:25, dgozman wrote: ...
3 years, 11 months ago (2016-12-30 00:14:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603053002/40001
3 years, 11 months ago (2016-12-30 00:14:34 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2016-12-30 01:44:25 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:54:00 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6f7a44a7e02604548056a6fbf18b69bbc1ff583a
Cr-Commit-Position: refs/heads/master@{#441012}

Powered by Google App Engine
This is Rietveld 408576698