Add Active Directory password change screen.

Add Active Directory password change screen.

BUG=676379
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=grt@chromium.org

Review-Url: https://codereview.chromium.org/2602973002
Cr-Commit-Position: refs/heads/master@{#444026}
Committed: https://chromium.googlesource.com/chromium/src/+/429c374b9e3b3a7400b1e5fbcfc3a18252e871cd

[Roman Sorokin (ftl), 2016-12-29 19:13:26]

Description was changed from

==========
Add Active Directory password change screen.

BUG=676379
==========

to

==========
Add Active Directory password change screen.

BUG=676379
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Roman Sorokin (ftl), 2016-12-29 19:15:06]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 19:15:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2016-12-29 19:15:47]

rsorokin@chromium.org changed reviewers:
+ alemate@google.com

[Roman Sorokin (ftl), 2016-12-29 19:15:48]

Hi Alex, PTAL. Thanks!

[Roman Sorokin (ftl), 2016-12-29 19:17:07]

rsorokin@chromium.org changed reviewers:
+ alemate@chromium.org
- alemate@google.com

[Roman Sorokin (ftl), 2016-12-29 19:17:07]

Sorry, wrong email

[commit-bot: I haz the power, 2016-12-29 20:22:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 20:22:08]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2017-01-11 01:48:38]

alemate@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Alexander Alekseev, 2017-01-11 01:48:39]

+michaelpg

Michael, this loks OK to me, but you know polymer better, and we also need
native speaker for strings and comments here.
Could you take a look?

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/login/active_directory_password_change.html
(right):

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.html:6:
<link rel="import"
href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
Do you need this?

Loading of all the icons takes significant amount of time, so we usually inline
the icons we need for the UI. See
https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/...
for an example.

[michaelpg, 2017-01-11 22:09:18]

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6243: Repeat new password
nit: "Confirm new password"

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6245: <message
name="IDS_AD_PASSWORD_CHANGE_MESSAGE" desc="Message to user on the Active
Directory password change dialog">
clarify this description.

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6246: <ph name="USER_NAME">$1</ph> is required
to change the password.
Can we rephrase this? Are we saying that <user>'s password has to be changed, or
that <user> has to be the one to change a password?

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6252: New passwords mismatch.
"New passwords don't match." or "Passwords don't match."

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/login/active_directory_password_change.html
(right):

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.html:6:
<link rel="import"
href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
On 2017/01/11 01:48:39, Alexander Alekseev wrote:
> Do you need this?
> 
> Loading of all the icons takes significant amount of time, so we usually
inline
> the icons we need for the UI. See
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/...
> for an example.

+1. Some documentation:
https://www.chromium.org/developers/updating-webui-for-material-design/using-...

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.html:22:
'authCompleted' - Fired when user enters old password and two times new one.
"and confirms new one."

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.html:27:
'repeatNewPassword': <typed repeated new password>,
Why pass this field? The confirmation field has already been validated when the
event is fired, right?

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/active_directory_password_change.js
(right):

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.js:8: 
nit: remove blank line

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.js:33:
this.$.welcomeMessage.innerText =
this would be simpler as a computed binding that returns the string, instead of
a change observer changes the DOM:

    <h1>[[computeWelcomeMessage_(username)]]</h1>

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.js:47:
this.$.animatedPages.selected += 1;
nit: use ++

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.js:53:
'repeatNewPassword': this.$.newPassword2.value,
redundant

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.css
(right):

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.css:5:

nit: remove blank line

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js
(right):

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js:8:

nit: remove blank line

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js:22:
this.cancel.bind(this));
wrong indent (align with 1st parameter)

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js:27:
[e.detail.username,
4-space indent

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js:42:
* Show password changed screen.
nit: Shows

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js:55:

nit: remove blank line

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:526: default:
shouldn't default go at the end?

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/oobe_screen.cc (right):

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/oobe_screen.cc:44: //
SCREEN_ACTIVE_DIRECTORY_PASSWORD_CHANGE
place comment above line (and indented the same as the line it comments)

https://codereview.chromium.org/2602973002/diff/1/ui/login/display_manager.js
File ui/login/display_manager.js (right):

https://codereview.chromium.org/2602973002/diff/1/ui/login/display_manager.js...
ui/login/display_manager.js:1009: * @param {string} username What user does
password change. Being used for
"Display name of the user whose password is being changed."

[Roman Sorokin (ftl), 2017-01-12 11:15:06]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 11:15:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 11:17:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 11:17:12]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Roman Sorokin (ftl), 2017-01-12 12:36:05]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 12:36:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-01-12 12:38:50]

Thanks for the review, Michael! PTAL.

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6243: Repeat new password
On 2017/01/11 22:09:09, michaelpg (NYC) wrote:
> nit: "Confirm new password"

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6245: <message
name="IDS_AD_PASSWORD_CHANGE_MESSAGE" desc="Message to user on the Active
Directory password change dialog">
On 2017/01/11 22:09:09, michaelpg (NYC) wrote:
> clarify this description.

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6246: <ph name="USER_NAME">$1</ph> is required
to change the password.
On 2017/01/11 22:09:09, michaelpg (NYC) wrote:
> Can we rephrase this? Are we saying that <user>'s password has to be changed,
or
> that <user> has to be the one to change a password?

User's password has to be changed. Not sure what is the best message.

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6252: New passwords mismatch.
On 2017/01/11 22:09:09, michaelpg (NYC) wrote:
> "New passwords don't match." or "Passwords don't match."

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/login/active_directory_password_change.html
(right):

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.html:6:
<link rel="import"
href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
On 2017/01/11 01:48:39, Alexander Alekseev wrote:
> Do you need this?
> 
> Loading of all the icons takes significant amount of time, so we usually
inline
> the icons we need for the UI. See
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/...
> for an example.

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.html:6:
<link rel="import"
href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
On 2017/01/11 22:09:09, michaelpg (NYC) wrote:
> On 2017/01/11 01:48:39, Alexander Alekseev wrote:
> > Do you need this?
> > 
> > Loading of all the icons takes significant amount of time, so we usually
> inline
> > the icons we need for the UI. See
> >
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/...
> > for an example.
> 
> +1. Some documentation:
>
https://www.chromium.org/developers/updating-webui-for-material-design/using-...

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.html:22:
'authCompleted' - Fired when user enters old password and two times new one.
On 2017/01/11 22:09:09, michaelpg (NYC) wrote:
> "and confirms new one."

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.html:27:
'repeatNewPassword': <typed repeated new password>,
On 2017/01/11 22:09:10, michaelpg (NYC) wrote:
> Why pass this field? The confirmation field has already been validated when
the
> event is fired, right?

I thought it was a good idea to pass all the info that was entered. Yes, it has
been validated. I guess we could remove that.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/active_directory_password_change.js
(right):

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.js:8: 
On 2017/01/11 22:09:11, michaelpg (NYC) wrote:
> nit: remove blank line

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.js:33:
this.$.welcomeMessage.innerText =
On 2017/01/11 22:09:13, michaelpg (NYC) wrote:
> this would be simpler as a computed binding that returns the string, instead
of
> a change observer changes the DOM:
> 
>     <h1>[[computeWelcomeMessage_(username)]]</h1>

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.js:47:
this.$.animatedPages.selected += 1;
On 2017/01/11 22:09:12, michaelpg (NYC) wrote:
> nit: use ++

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/active_directory_password_change.js:53:
'repeatNewPassword': this.$.newPassword2.value,
On 2017/01/11 22:09:12, michaelpg (NYC) wrote:
> redundant

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.css
(right):

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.css:5:

On 2017/01/11 22:09:13, michaelpg (NYC) wrote:
> nit: remove blank line

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js
(right):

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js:8:

On 2017/01/11 22:09:14, michaelpg (NYC) wrote:
> nit: remove blank line

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js:22:
this.cancel.bind(this));
On 2017/01/11 22:09:13, michaelpg (NYC) wrote:
> wrong indent (align with 1st parameter)

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js:27:
[e.detail.username,
On 2017/01/11 22:09:14, michaelpg (NYC) wrote:
> 4-space indent

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js:42:
* Show password changed screen.
On 2017/01/11 22:09:15, michaelpg (NYC) wrote:
> nit: Shows

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js:55:

On 2017/01/11 22:09:14, michaelpg (NYC) wrote:
> nit: remove blank line

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:526: default:
On 2017/01/11 22:09:15, michaelpg (NYC) wrote:
> shouldn't default go at the end?

Done.

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/oobe_screen.cc (right):

https://codereview.chromium.org/2602973002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/oobe_screen.cc:44: //
SCREEN_ACTIVE_DIRECTORY_PASSWORD_CHANGE
On 2017/01/11 22:09:15, michaelpg (NYC) wrote:
> place comment above line (and indented the same as the line it comments)

Done.

[commit-bot: I haz the power, 2017-01-12 12:45:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 12:45:57]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[michaelpg, 2017-01-12 16:54:14]

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6246: <ph name="USER_NAME">$1</ph> is required
to change the password.
On 2017/01/12 12:38:50, Roman Sorokin wrote:
> On 2017/01/11 22:09:09, michaelpg (NYC) wrote:
> > Can we rephrase this? Are we saying that <user>'s password has to be
changed,
> or
> > that <user> has to be the one to change a password?
> 
> User's password has to be changed. Not sure what is the best message.

Can you ask someone from UX?

[Roman Sorokin (ftl), 2017-01-12 16:57:37]

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2602973002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6246: <ph name="USER_NAME">$1</ph> is required
to change the password.
On 2017/01/12 16:54:14, michaelpg (NYC) wrote:
> On 2017/01/12 12:38:50, Roman Sorokin wrote:
> > On 2017/01/11 22:09:09, michaelpg (NYC) wrote:
> > > Can we rephrase this? Are we saying that <user>'s password has to be
> changed,
> > or
> > > that <user> has to be the one to change a password?
> > 
> > User's password has to be changed. Not sure what is the best message.
> 
> Can you ask someone from UX?

Yep. On it. Thanks!

[michaelpg, 2017-01-12 17:22:00]

https://codereview.chromium.org/2602973002/diff/20001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2602973002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6245: <message
name="IDS_AD_PASSWORD_CHANGE_MESSAGE" desc="Message to the user meaning Active
Directory administrator requires to change user's password">
"Message to the user that the Active Directory administrator requires the user
to change his/her password."

https://codereview.chromium.org/2602973002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6246: <ph name="USER_NAME">$1</ph>,
administrator requires you to change your password
your administrator

https://codereview.chromium.org/2602973002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/login/active_directory_password_change.html
(right):

https://codereview.chromium.org/2602973002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/active_directory_password_change.html:21:
'authCompleted' - Fired when user enters old password  and confirms new one.
nit: remove double space

[Roman Sorokin (ftl), 2017-01-16 16:52:30]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 16:52:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-01-16 16:53:29]

Hey Michael, please take a look.
UX team have not responded yet about the message, so I might change it in the
separate CL.

https://codereview.chromium.org/2602973002/diff/20001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2602973002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6245: <message
name="IDS_AD_PASSWORD_CHANGE_MESSAGE" desc="Message to the user meaning Active
Directory administrator requires to change user's password">
On 2017/01/12 17:22:00, michaelpg wrote:
> "Message to the user that the Active Directory administrator requires the user
> to change his/her password."

Done.

https://codereview.chromium.org/2602973002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6246: <ph name="USER_NAME">$1</ph>,
administrator requires you to change your password
On 2017/01/12 17:22:00, michaelpg wrote:
> your administrator

Done.

https://codereview.chromium.org/2602973002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/login/active_directory_password_change.html
(right):

https://codereview.chromium.org/2602973002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/active_directory_password_change.html:21:
'authCompleted' - Fired when user enters old password  and confirms new one.
On 2017/01/12 17:22:00, michaelpg wrote:
> nit: remove double space

Done.

[commit-bot: I haz the power, 2017-01-16 17:47:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 17:47:12]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2017-01-16 18:04:42]

lgtm

https://codereview.chromium.org/2602973002/diff/60001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2602973002/diff/60001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6258: <ph name="USER_NAME">$1</ph>, your
administrator requires you to change your password
nit: ending period?

https://codereview.chromium.org/2602973002/diff/60001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6263: <message
name="IDS_AD_PASSWORD_CHANGE_PASSWORDS_MISMATCH" desc="Error message in case new
password fields does not match on the Active Directory password change dialog.">
"do not match"

https://codereview.chromium.org/2602973002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js
(right):

https://codereview.chromium.org/2602973002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js:29:
}.bind(this));
no need to bind to |this|

https://codereview.chromium.org/2602973002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/2602973002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:522: case
authpolicy::ERROR_PASSWORD_EXPIRED: {
nit: {} block not necessary

[Roman Sorokin (ftl), 2017-01-17 10:32:36]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 10:32:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-01-17 10:33:44]

https://codereview.chromium.org/2602973002/diff/60001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2602973002/diff/60001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6258: <ph name="USER_NAME">$1</ph>, your
administrator requires you to change your password
On 2017/01/16 18:04:42, michaelpg wrote:
> nit: ending period?

Done.

https://codereview.chromium.org/2602973002/diff/60001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6263: <message
name="IDS_AD_PASSWORD_CHANGE_PASSWORDS_MISMATCH" desc="Error message in case new
password fields does not match on the Active Directory password change dialog.">
On 2017/01/16 18:04:42, michaelpg wrote:
> "do not match"

Done.

https://codereview.chromium.org/2602973002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js
(right):

https://codereview.chromium.org/2602973002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js:29:
}.bind(this));
On 2017/01/16 18:04:42, michaelpg wrote:
> no need to bind to |this|

Done.

[Alexander Alekseev, 2017-01-17 10:41:18]

lgtm

[Roman Sorokin (ftl), 2017-01-17 10:42:35]

The CQ bit was checked by rsorokin@chromium.org

[Roman Sorokin (ftl), 2017-01-17 10:42:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2602973002/#ps80001
(title: "nits")

[commit-bot: I haz the power, 2017-01-17 10:42:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-01-17 10:49:21]

Description was changed from

==========
Add Active Directory password change screen.

BUG=676379
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add Active Directory password change screen.

BUG=676379
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=grt@chromium.org
==========

[commit-bot: I haz the power, 2017-01-17 11:33:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484649755030560,
"parent_rev": "2ef6d3ba0eecb7bbc12671f83ac8adfea0b9c00b", "commit_rev":
"429c374b9e3b3a7400b1e5fbcfc3a18252e871cd"}

[commit-bot: I haz the power, 2017-01-17 11:34:22]

Description was changed from

==========
Add Active Directory password change screen.

BUG=676379
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=grt@chromium.org
==========

to

==========
Add Active Directory password change screen.

BUG=676379
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=grt@chromium.org

Review-Url: https://codereview.chromium.org/2602973002
Cr-Commit-Position: refs/heads/master@{#444026}
Committed:
https://chromium.googlesource.com/chromium/src/+/429c374b9e3b3a7400b1e5fbcfc3...
==========

[commit-bot: I haz the power, 2017-01-17 11:34:23]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/429c374b9e3b3a7400b1e5fbcfc3...