Factor iOS native image loading into a utility function.

Factor iOS native image loading into a utility function.

This CL packages the fairly common code path where a gfx image is
extracted from the shared bundle and converted into a UIImage into a
single utility function. All of the applicable call sites in
ios/chrome/browser/ui/ are updated to use the function, and
includes that were only present to support this code are removed.

BUG=

Committed: https://crrev.com/120110630f924c00c1eddb141d61f9da87d01bbf
Cr-Commit-Position: refs/heads/master@{#440875}

[marq (ping after 24h), 2016-12-28 17:05:29]

marq@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[marq (ping after 24h), 2016-12-28 17:07:10]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 17:07:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 17:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 17:14:06]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Olivier, 2016-12-28 17:45:30]

lgtm

[marq (ping after 24h), 2016-12-28 18:03:48]

Fixed BUILD files.

[marq (ping after 24h), 2016-12-28 18:03:48]

The CQ bit was checked by marq@chromium.org

[marq (ping after 24h), 2016-12-28 18:03:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
olivierrobin@chromium.org
Link to the patchset: https://codereview.chromium.org/2602903002/#ps20001
(title: "Fixed BUILD files.")

[commit-bot: I haz the power, 2016-12-28 18:03:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 18:59:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482948228848010,
"parent_rev": "ca3c04b5c69dc6198d888825c1d337471114d9a9", "commit_rev":
"068360a27e2a23a0998082a4ac7f2219a0bbe043"}

[commit-bot: I haz the power, 2016-12-28 18:59:57]

Description was changed from

==========
Factor iOS native image loading into a utility function.

This CL packages the fairly common code path where a gfx image is
extracted from the shared bundle and converted into a UIImage into a
single utility function. All of the applicable call sites in
ios/chrome/browser/ui/ are updated to use the function, and
includes that were only present to support this code are removed.

BUG=
==========

to

==========
Factor iOS native image loading into a utility function.

This CL packages the fairly common code path where a gfx image is
extracted from the shared bundle and converted into a UIImage into a
single utility function. All of the applicable call sites in
ios/chrome/browser/ui/ are updated to use the function, and
includes that were only present to support this code are removed.

BUG=

Review-Url: https://codereview.chromium.org/2602903002
==========

[commit-bot: I haz the power, 2016-12-28 18:59:58]

Committed patchset #2 (id:20001)

[noyau (Ping after 24h), 2017-01-02 10:11:31]

noyau@chromium.org changed reviewers:
+ noyau@chromium.org

[noyau (Ping after 24h), 2017-01-02 10:11:32]

https://codereview.chromium.org/2602903002/diff/20001/ios/chrome/browser/ui/u...
File ios/chrome/browser/ui/uikit_ui_util.mm (right):

https://codereview.chromium.org/2602903002/diff/20001/ios/chrome/browser/ui/u...
ios/chrome/browser/ui/uikit_ui_util.mm:240: return
NativeReversableImage(imageID, NO);
Late driveby: Will this now reverse all images if UseRTLLayout() is true,
whereas before only the ones explicitely reversable were reversed?

[commit-bot: I haz the power, 2017-01-02 15:49:47]

Description was changed from

==========
Factor iOS native image loading into a utility function.

This CL packages the fairly common code path where a gfx image is
extracted from the shared bundle and converted into a UIImage into a
single utility function. All of the applicable call sites in
ios/chrome/browser/ui/ are updated to use the function, and
includes that were only present to support this code are removed.

BUG=

Review-Url: https://codereview.chromium.org/2602903002
==========

to

==========
Factor iOS native image loading into a utility function.

This CL packages the fairly common code path where a gfx image is
extracted from the shared bundle and converted into a UIImage into a
single utility function. All of the applicable call sites in
ios/chrome/browser/ui/ are updated to use the function, and
includes that were only present to support this code are removed.

BUG=

Committed: https://crrev.com/120110630f924c00c1eddb141d61f9da87d01bbf
Cr-Commit-Position: refs/heads/master@{#440875}
==========

[commit-bot: I haz the power, 2017-01-02 15:49:48]

Patchset 2 (id:??) landed as
https://crrev.com/120110630f924c00c1eddb141d61f9da87d01bbf
Cr-Commit-Position: refs/heads/master@{#440875}

[marq (ping after 24h), 2017-01-09 09:46:14]

https://codereview.chromium.org/2602903002/diff/20001/ios/chrome/browser/ui/u...
File ios/chrome/browser/ui/uikit_ui_util.mm (right):

https://codereview.chromium.org/2602903002/diff/20001/ios/chrome/browser/ui/u...
ios/chrome/browser/ui/uikit_ui_util.mm:240: return
NativeReversableImage(imageID, NO);
On 2017/01/02 10:11:32, noyau wrote:
> Late driveby: Will this now reverse all images if UseRTLLayout() is true,
> whereas before only the ones explicitely reversable were reversed?

NativeImage(image_id) will never reverse the image.

NativeReversableImage(image_id, YES) will reverse the image if RTLLayout() is
true; this (passing in YES) is how images are marked as explicitly reversible.

(I should fix the spelling of 'Reversable', however).