ios/chrome/browser/ui/infobars/infobar_view.mm - Issue 2602903002: Factor iOS native image loading into a utility function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/infobars/infobar_view.mm

Issue 2602903002: Factor iOS native image loading into a utility function. (Closed)

Patch Set: Fixed BUILD files. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/infobars/infobar_view.mm

diff --git a/ios/chrome/browser/ui/infobars/infobar_view.mm b/ios/chrome/browser/ui/infobars/infobar_view.mm

index 7b2ffc02b57c5668281fd47bc0b781f2e66d6f88..23d4b1ababee9b4c0b465eba5f043ef906b08ef5 100644

--- a/ios/chrome/browser/ui/infobars/infobar_view.mm

+++ b/ios/chrome/browser/ui/infobars/infobar_view.mm

@@ -658,8 +658,7 @@ enum InfoBarButtonPosition { ON_FIRST_LINE, CENTER, LEFT, RIGHT };

target:(id)target

action:(SEL)action {

DCHECK(!closeButton_);

- // TODO(jeanfrancoisg): Add IDR_ constant and use GetNativeImageNamed().

- // crbug/228611

+ // TODO(crbug/228611): Add IDR_ constant and use GetNativeImageNamed().

NSString* imagePath =

[[NSBundle mainBundle] pathForResource:@"infobar_close" ofType:@"png"];

UIImage* image = [UIImage imageWithContentsOfFile:imagePath];