Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2602813002: Disable contextual search if the FRE has not been completed. (Closed)

Created:
3 years, 11 months ago by Ted C
Modified:
3 years, 11 months ago
Reviewers:
Donn Denman, Theresa
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable contextual search if the FRE has not been completed. BUG=673522 Committed: https://crrev.com/3746e638dd83ea76ea0aa45cd2ef595527bf8c0f Cr-Commit-Position: refs/heads/master@{#440898}

Patch Set 1 #

Patch Set 2 : Fix pref clearing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 1 5 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
Ted C
PTAL
3 years, 11 months ago (2016-12-28 19:50:05 UTC) #10
Theresa
lgtm
3 years, 11 months ago (2016-12-28 21:55:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602813002/20001
3 years, 11 months ago (2016-12-28 21:57:22 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7c5ba8c6f23a6ec7d74b9087f2a956ba729d7811
3 years, 11 months ago (2016-12-28 22:02:19 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:50:29 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3746e638dd83ea76ea0aa45cd2ef595527bf8c0f
Cr-Commit-Position: refs/heads/master@{#440898}

Powered by Google App Engine
This is Rietveld 408576698