chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java - Issue 2602813002: Disable contextual search if the FRE has not been completed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java

Issue 2602813002: Disable contextual search if the FRE has not been completed. (Closed)

Patch Set: Fix pref clearing Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java

index bc7459576722edfd2e4cee25d91bb8e1203c8249..52ba3123426da05c4dfa8aec265c8640f16df656 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java

@@ -10,6 +10,7 @@ import android.view.ContextMenu;

import org.chromium.base.annotations.CalledByNative;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;

+import org.chromium.chrome.browser.firstrun.FirstRunStatus;

import org.chromium.chrome.browser.preferences.PrefServiceBridge;

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.chrome.browser.search_engines.TemplateUrlService;

@@ -216,6 +217,7 @@ public class ContextualSearchTabHelper

if (manager == null) return false;

return !cvc.getWebContents().isIncognito()

+ && FirstRunStatus.getFirstRunFlowComplete()

&& !PrefServiceBridge.getInstance().isContextualSearchDisabled()

&& TemplateUrlService.getInstance().isDefaultSearchEngineGoogle()

// Svelte and Accessibility devices are incompatible with the first-run flow and