Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2602723002: binding: Simplify v8DateOrNaN(). (Closed)

Created:
3 years, 12 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
haraken, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Simplify v8DateOrNaN(). isfinite() check is unnecessary here because -Infinity and +Infinity will be converted to NaN in i::JSDate::New(), which is called by v8::Date::New. This CL has no behavior changes. Committed: https://crrev.com/ea14a17be1f3e266099bc9f9051a612fb541a1fc Cr-Commit-Position: refs/heads/master@{#440745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
tkent
bashi@, would you review this please?
3 years, 12 months ago (2016-12-27 06:44:39 UTC) #4
bashi
lgtm
3 years, 12 months ago (2016-12-27 07:16:37 UTC) #5
haraken
LGTM
3 years, 12 months ago (2016-12-27 07:21:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602723002/1
3 years, 12 months ago (2016-12-27 08:55:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-27 09:00:23 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:45:56 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea14a17be1f3e266099bc9f9051a612fb541a1fc
Cr-Commit-Position: refs/heads/master@{#440745}

Powered by Google App Engine
This is Rietveld 408576698