Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

Issue 2602723002: binding: Simplify v8DateOrNaN(). (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
index 29a5a4606e92e0b8b66e3d22d4a0aa7f1f40c8e4..ddcb4714f68a66281cc840bca4f51e90d54ec735 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
@@ -658,9 +658,7 @@ inline double toCoreDate(v8::Isolate* isolate,
inline v8::MaybeLocal<v8::Value> v8DateOrNaN(v8::Isolate* isolate,
double value) {
ASSERT(isolate);
- return v8::Date::New(
- isolate->GetCurrentContext(),
- std::isfinite(value) ? value : std::numeric_limits<double>::quiet_NaN());
+ return v8::Date::New(isolate->GetCurrentContext(), value);
}
// FIXME: Remove the special casing for NodeFilter and XPathNSResolver.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698